From: Paolo Abeni <pabeni@redhat.com>
To: Jason Xing <kerneljasonxing@gmail.com>,
edumazet@google.com, dsahern@kernel.org, matttbe@kernel.org,
martineau@kernel.org, geliang@kernel.org, kuba@kernel.org,
davem@davemloft.net, rostedt@goodmis.org, mhiramat@kernel.org,
mathieu.desnoyers@efficios.com, atenart@kernel.org
Cc: mptcp@lists.linux.dev, netdev@vger.kernel.org,
Jason Xing <kernelxing@tencent.com>
Subject: Re: [PATCH net-next v4 5/6] mptcp: support rstreason for passive reset
Date: Tue, 16 Apr 2024 10:04:30 +0200 [thread overview]
Message-ID: <3b53762fbdfb7df1b3e79ea5138fabb714449d28.camel@redhat.com> (raw)
In-Reply-To: <20240411115630.38420-6-kerneljasonxing@gmail.com>
On Thu, 2024-04-11 at 19:56 +0800, Jason Xing wrote:
> diff --git a/net/mptcp/subflow.c b/net/mptcp/subflow.c
> index ba0a252c113f..25eaad94cb79 100644
> --- a/net/mptcp/subflow.c
> +++ b/net/mptcp/subflow.c
> @@ -308,8 +308,12 @@ static struct dst_entry *subflow_v4_route_req(const struct sock *sk,
> return dst;
>
> dst_release(dst);
> - if (!req->syncookie)
> - tcp_request_sock_ops.send_reset(sk, skb, SK_RST_REASON_NOT_SPECIFIED);
> + if (!req->syncookie) {
> + struct mptcp_ext *mpext = mptcp_get_ext(skb);
> + enum sk_rst_reason reason = convert_mptcp_reason(mpext->reset_reason);
Since you already have to repost, very minor nit: even the above
strictly speaking does not respect the reverse xmass tree.
enum sk_rst_reason reason;
reason = convert_mptcp_reason(mpext->reset_reason);
> + tcp_request_sock_ops.send_reset(sk, skb, reason);
Cheers,
Paolo
next prev parent reply other threads:[~2024-04-16 8:04 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-11 11:56 [PATCH net-next v4 0/6] Implement reset reason mechanism to detect Jason Xing
2024-04-11 11:56 ` [PATCH net-next v4 1/6] net: introduce rstreason to detect why the RST is sent Jason Xing
2024-04-11 11:56 ` [PATCH net-next v4 2/6] rstreason: prepare for passive reset Jason Xing
2024-04-11 11:56 ` [PATCH net-next v4 3/6] rstreason: prepare for active reset Jason Xing
2024-04-16 8:01 ` Paolo Abeni
2024-04-16 8:27 ` Jason Xing
2024-04-11 11:56 ` [PATCH net-next v4 4/6] tcp: support rstreason for passive reset Jason Xing
2024-04-16 6:34 ` Eric Dumazet
2024-04-16 7:45 ` Jason Xing
2024-04-16 12:24 ` Jason Xing
2024-04-16 20:22 ` Matthieu Baerts
2024-04-17 0:23 ` Jason Xing
2024-04-11 11:56 ` [PATCH net-next v4 5/6] mptcp: " Jason Xing
2024-04-16 6:33 ` Eric Dumazet
2024-04-16 7:45 ` Jason Xing
2024-04-16 8:04 ` Paolo Abeni [this message]
2024-04-16 8:19 ` Jason Xing
2024-04-11 11:56 ` [PATCH net-next v4 6/6] rstreason: make it work in trace world Jason Xing
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3b53762fbdfb7df1b3e79ea5138fabb714449d28.camel@redhat.com \
--to=pabeni@redhat.com \
--cc=atenart@kernel.org \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=geliang@kernel.org \
--cc=kerneljasonxing@gmail.com \
--cc=kernelxing@tencent.com \
--cc=kuba@kernel.org \
--cc=martineau@kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=matttbe@kernel.org \
--cc=mhiramat@kernel.org \
--cc=mptcp@lists.linux.dev \
--cc=netdev@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).