From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C22D8C43381 for ; Tue, 26 Feb 2019 15:13:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8DC0A2173C for ; Tue, 26 Feb 2019 15:13:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Rawj5Dxz" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727638AbfBZPNN (ORCPT ); Tue, 26 Feb 2019 10:13:13 -0500 Received: from mail-pg1-f195.google.com ([209.85.215.195]:42493 "EHLO mail-pg1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726475AbfBZPNM (ORCPT ); Tue, 26 Feb 2019 10:13:12 -0500 Received: by mail-pg1-f195.google.com with SMTP id b2so6346108pgl.9 for ; Tue, 26 Feb 2019 07:13:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=Llu3f9aW6Qihpa7ANYTEsvjFEOiFHkblrrAiksgkhpc=; b=Rawj5DxzS6gLpsIYLCr1LEezl9LO5Dc/9HFq1T22A0u6KrNVW32SJ722uKOWvJw5Dy J/IS2A/3UT5LB7r4H+Sk1ofkrzlPS14sSpKXDy7CBZc+qT1PYo9pc5BYUYtOFCYv2y7+ 54VpFajayGZwWGheppoY+kg+ka0XeioG8oHHUoLt0Vo/OQL23N5hvM+u3F0M4lhJAWdo h/ClsxFUfDJt654Qb5PRpNbpVJWfDSPFIjDLaYhE4opQ4HZsphQ9n47nrb6A09N3wpVx 3VjZMwLXA/6RNptBF2pR2AU1LCBpXo/+dtT9kXOMGNmoamfI6aSHx5EdfbOOMLSFAAMx DfHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Llu3f9aW6Qihpa7ANYTEsvjFEOiFHkblrrAiksgkhpc=; b=OI8sRSOwJKRT57itYNFvjR/gCBin6xJkSaSfi/BYLNn/hbXBpbXFQlyLeDqWbuW84s 7ja+LLrpaYZQLNz1iBqt3mz+b49qrZxA0Ooc8qR9v/emgppM496761BsEGY4Gja450FN U3eKQodDSKxpvPUJNlFBrWej9Zcn+6O/zMVPNaFOrdfwvcuNUu3C4kRGf3Fij7qnhWpS +6Vb2IXqmvJtQGpp0epB5wGNoTtkDecAqXtQ9Q2hPpCbL+xf/hBDIZrG0zMQ+BAOSDMR tbHfH8PRW40UIJkPYgjLFIRoWDo1u/kfwqZL/tdgNufFThs4eaKf+MVjEBhNYBorcLcZ L7+w== X-Gm-Message-State: AHQUAua4izQHLD3qQLx2vmsuIYefzDSq2MGGOlWSPrQTQIH3FOcfcv2j HxrgV8PTsTyfsAXS5WX+EfQ= X-Google-Smtp-Source: AHgI3IbNFmGBoyFX1VKckj6GVHrFlXb2bVrc9qxVD73a01ggiHMQxs7zdl59JF58YwxqHMt4tcpGDg== X-Received: by 2002:a63:235b:: with SMTP id u27mr25139517pgm.262.1551193992326; Tue, 26 Feb 2019 07:13:12 -0800 (PST) Received: from [192.168.86.235] (c-73-241-150-70.hsd1.ca.comcast.net. [73.241.150.70]) by smtp.gmail.com with ESMTPSA id d86sm870212pfm.18.2019.02.26.07.13.10 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 26 Feb 2019 07:13:11 -0800 (PST) Subject: Re: [PATCH net] tcp: repaired skbs must init their tso_segs To: Andrei Vagin , Eric Dumazet Cc: "David S . Miller" , netdev , Eric Dumazet , Soheil Hassas Yeganeh , Neal Cardwell , Yuchung Cheng , syzbot , Andrey Vagin References: <20190223235151.168283-1-edumazet@google.com> <20190226092302.GA25925@gmail.com> From: Eric Dumazet Message-ID: <3ba2ef25-d535-b215-88d7-cf065b69b625@gmail.com> Date: Tue, 26 Feb 2019 07:13:10 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20190226092302.GA25925@gmail.com> Content-Type: text/plain; charset=koi8-r Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 02/26/2019 01:23 AM, Andrei Vagin wrote: > > Thank you Eric. I saw a few test fails when tcp_peek_sndq() > returned more data than we expected. I have executed the test with this > fix in a loop and it works without any problem. Without this fix, it > fails after a few iteration. > > https://github.com/checkpoint-restore/criu/issues/622 > Hi Andrei. Thanks for testing !