From: Tilman Schmidt <tilman@imap.cc>
To: Karsten Keil <isdn@linux-pingi.de>, David Miller <davem@davemloft.net>
Cc: Hansjoerg Lipp <hjlipp@web.de>,
Alan Cox <alan@lxorguk.ukuu.org.uk>,
isdn4linux <isdn4linux@listserv.isdn4linux.de>,
i4ldeveloper <i4ldeveloper@listserv.isdn4linux.de>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org
Subject: [PATCH 3/3] gigaset: prune use of tty_buffer_request_room
Date: Sun, 14 Mar 2010 23:58:05 +0100 (CET) [thread overview]
Message-ID: <3ba816ff92f2dad24a5265f8f213a63debe9c6e6.1268580322.git.tilman@imap.cc> (raw)
In-Reply-To: <cover.1268580322.git.tilman@imap.cc>
Calling tty_buffer_request_room() before tty_insert_flip_string()
is unnecessary, costs CPU and for big buffers can mess up the
multi-page allocation avoidance.
Signed-off-by: Tilman Schmidt <tilman@imap.cc>
CC: Alan Cox <alan@lxorguk.ukuu.org.uk>, stable@kernel.org
---
Note to -stable: applies correctly to 2.6.33 with fuzz 2.
drivers/isdn/gigaset/interface.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/drivers/isdn/gigaset/interface.c b/drivers/isdn/gigaset/interface.c
index a1bcbc2..f0dc6c9 100644
--- a/drivers/isdn/gigaset/interface.c
+++ b/drivers/isdn/gigaset/interface.c
@@ -628,7 +628,6 @@ void gigaset_if_receive(struct cardstate *cs,
if (tty == NULL)
gig_dbg(DEBUG_IF, "receive on closed device");
else {
- tty_buffer_request_room(tty, len);
tty_insert_flip_string(tty, buffer, len);
tty_flip_buffer_push(tty);
}
--
1.6.5.3.298.g39add
next prev parent reply other threads:[~2010-03-14 22:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-14 22:58 [PATCH 0/3] gigaset fixes for 2.6.34-rc1 Tilman Schmidt
2010-03-14 22:58 ` [PATCH 1/3] gigaset: avoid registering CAPI driver more than once Tilman Schmidt
2010-03-14 22:58 ` Tilman Schmidt [this message]
2010-03-14 22:58 ` [PATCH 2/3] gigaset: correct clearing of at_state strings on RING Tilman Schmidt
2010-03-15 15:00 ` [PATCH 0/3] gigaset fixes for 2.6.34-rc1 Karsten Keil
2010-03-15 23:06 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3ba816ff92f2dad24a5265f8f213a63debe9c6e6.1268580322.git.tilman@imap.cc \
--to=tilman@imap.cc \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=davem@davemloft.net \
--cc=hjlipp@web.de \
--cc=i4ldeveloper@listserv.isdn4linux.de \
--cc=isdn4linux@listserv.isdn4linux.de \
--cc=isdn@linux-pingi.de \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).