From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 91217C10F13 for ; Mon, 8 Apr 2019 18:45:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 625D720833 for ; Mon, 8 Apr 2019 18:45:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="lWio+D/I" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728677AbfDHSpz (ORCPT ); Mon, 8 Apr 2019 14:45:55 -0400 Received: from mail-wr1-f67.google.com ([209.85.221.67]:46431 "EHLO mail-wr1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726352AbfDHSpy (ORCPT ); Mon, 8 Apr 2019 14:45:54 -0400 Received: by mail-wr1-f67.google.com with SMTP id t17so17596479wrw.13 for ; Mon, 08 Apr 2019 11:45:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=DRsXw8vdqlaU16GH1AIOETT5ndN2KlmK3ANCQcIujFI=; b=lWio+D/I8wk7C3mPjrTwQVZcLVb/FcTh99lVq5BuqDcCWQFHGPywD8WxvFRCHvsPX+ mHmoc4YOm6dKgqHTsymo5616syiSo4rmsUnqln+5RvwKAtnCT/MO7asnHLK+M/RvzNAm apw+XgoMHifRF5ERnhQl71EaqMi9MI+RTlYILOzaOeYjWit44T8N9v79/kIxcnaLXmSK /b23g9ZYu2YKGFxdoJHvi0cL0P1fGPdZRrzMCV7YEnwAjwFhCFjsDlmj3sHMy1VrH5On oAyVtBcV8koN6FJaRgvnq9OjorHbqVbx9cE6ofyjBIodHhZKrDEkxtCTmLbTEmss9+bQ AzGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=DRsXw8vdqlaU16GH1AIOETT5ndN2KlmK3ANCQcIujFI=; b=uLOemeQ8ofJXm6Sc4QN/EJkSMN38wgJuAY2batPJJrF0AQVh6Te+vkpvwWXalJw1Df viCJ70PNIqiDjiy2JKA1fRoRToAAN/fbw3eJAkAqbamxiW7mLGP7a+3cT+ZJ7B2F51B4 ohtyMgXOwzHqeIIR0tyXndbgoP7/nHpQVa/EMDQmNL8dzyt4QWszdAGy/2JNEM55eYEp nBBj7mQJ0c51YXT9j7z3n80SadjnsnDCm908p5rV8sBrAbSXPQLZcuaaZRXGCUMr+i1z MYja0zu6d2a8yh8wQJNLTJAgPVl3wMi5Bc+kHLWbm4kklQQkrS8zIEcefvFuMbGbeBG0 t+vQ== X-Gm-Message-State: APjAAAVrAIYr+MqPM8pG/xR38/nSEU9+qlbKwS/qdWxHhDhwlOwOYdj0 24QBWzMCmcqVoWrs4Q+WTCI= X-Google-Smtp-Source: APXvYqxZ6/QCjFdeo1IpahAZCPAc1l1JhXWZ6NIG8bVNPaMlHgV7/VwcL/DyQScGa0n5Byt/1JHuGQ== X-Received: by 2002:adf:f80d:: with SMTP id s13mr19462154wrp.38.1554749153176; Mon, 08 Apr 2019 11:45:53 -0700 (PDT) Received: from ?IPv6:2003:ea:8bde:d800:1488:bc0a:4c8c:6b35? (p200300EA8BDED8001488BC0A4C8C6B35.dip0.t-ipconnect.de. [2003:ea:8bde:d800:1488:bc0a:4c8c:6b35]) by smtp.googlemail.com with ESMTPSA id s2sm12832600wmc.7.2019.04.08.11.45.52 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 08 Apr 2019 11:45:52 -0700 (PDT) Subject: Re: [PATCH net-next] net: phy: switch drivers to use dynamic feature detection To: Andrew Lunn Cc: Florian Fainelli , David Miller , Ray Jui , Scott Branden , Richard Cochran , Kevin Hilman , Heiko Stuebner , bcm-kernel-feedback-list@broadcom.com, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-rockchip@lists.infradead.org References: <0cc96fab-e102-c0d1-ade0-90e3e06dc9f1@gmail.com> <20190407221312.GA14347@lunn.ch> <20190408181249.GH15267@lunn.ch> From: Heiner Kallweit Message-ID: <3bc293a8-5966-fb40-e0b1-636f3a3dfe77@gmail.com> Date: Mon, 8 Apr 2019 20:45:45 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190408181249.GH15267@lunn.ch> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 08.04.2019 20:12, Andrew Lunn wrote: >> Splitting the series and waiting for a Tested-by, as proposed by Richard, >> may be problematic because most PHY drivers don't have a dedicated >> maintainer, and we lack the hardware to test. > > Well, we could split out those we know are likely to get tested. I > have a number of boards with Marvell devices i can test. Florian has > Broadcom boards. I also have a couple of boards with Micrel KSZ8041, > which would be interesting because they are Fast Ethernet. Bootlin can > test some of the mscc PHYs. > Great. Could you also test based on the series and the provide a Tested-by for the PHY's which have been tested? Even if I split out let's say the Marvell PHY driver, most likely just few of all the supported Marvell PHY's can be tested. > We also might want to get some targeted testing. The microchip_t1.c > could be interesting, since it is a T1 device. There was another T1 > added in the last year, but i forget which. > The T1 PHY driver isn't included in this series. It uses another feature constant: PHY_BASIC_T1_FEATURES > Just doing this testing might give us an idea if we really should > expect problems. > Sure. I tested and applied this change to the Realtek PHY driver already. > Andrew > Heiner