From: Florian Fainelli <f.fainelli@gmail.com>
To: Russell King - ARM Linux <linux@armlinux.org.uk>
Cc: "David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, Andrew Lunn <andrew@lunn.ch>
Subject: Re: [PATCH RFC v2 3/3] net: phy: allow EEE with SGMII interface modes
Date: Mon, 27 Mar 2017 15:42:57 -0700 [thread overview]
Message-ID: <3bcc3380-6e59-06e3-9ebd-5450e89c90a2@gmail.com> (raw)
In-Reply-To: <20170327201529.GT7909@n2100.armlinux.org.uk>
On 03/27/2017 01:15 PM, Russell King - ARM Linux wrote:
> Here's the revised patch as requested.
>
> Thanks.
>
> 8<===
> From: Russell King <rmk+kernel@armlinux.org.uk>
> Subject: [PATCH] net: phy: allow EEE with any interface mode
>
> EEE is able to work in any PHY interface mode, there is nothing which
> fundamentally restricts it to only a few modes. For example, EEE works
> in SGMII mode with the Marvell 88E1512.
>
> Rather than just adding SGMII mode to the list, Florian suggests
> removing the list of interface modes entirely:
>
> It actually sounds like we should just kill the check entirely,
> it does not appear that any of the interface mode would not
> fundamentally be able to support EEE, because the "lowest" mode
> we support is MII, and even there it's quite possible to support
> EEE.
>
> Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
I think David will require you to resubmit this as an entire patch
series and without an RFC tag. Do you want to hold off a bit to get
build coverage or go ahead and target net-next right away?
Thanks!
--
Florian
next prev parent reply other threads:[~2017-03-27 22:43 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-27 9:58 [PATCH RFC v2 0/3] phylib EEE updates Russell King - ARM Linux
2017-03-27 9:58 ` [PATCH RFC v2 1/3] net: phy: avoid setting unsupported EEE advertisments Russell King
2017-03-27 18:04 ` Florian Fainelli
2017-03-27 9:58 ` [PATCH RFC v2 2/3] net: phy: restart phy autonegotiation after EEE advertisment change Russell King
2017-03-27 18:03 ` Florian Fainelli
2017-03-27 9:59 ` [PATCH RFC v2 3/3] net: phy: allow EEE with SGMII interface modes Russell King
2017-03-27 16:47 ` Florian Fainelli
2017-03-27 17:00 ` Russell King - ARM Linux
2017-03-27 18:03 ` Florian Fainelli
2017-03-27 19:47 ` Russell King - ARM Linux
2017-03-27 19:48 ` Florian Fainelli
2017-03-27 20:15 ` Russell King - ARM Linux
2017-03-27 22:42 ` Florian Fainelli [this message]
2017-03-27 22:47 ` Russell King - ARM Linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3bcc3380-6e59-06e3-9ebd-5450e89c90a2@gmail.com \
--to=f.fainelli@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).