From: Shuah Khan <shuah@kernel.org>
To: Sowmini Varadhan <sowmini.varadhan@oracle.com>
Cc: linux-kselftest@vger.kernel.org, netdev@vger.kernel.org,
daniel@iogearbox.net, willemb@google.com, davem@davemloft.net,
Shuah Khan <shuah@kernel.org>
Subject: Re: [PATCH v3 net-next 1/2] tools: psock_lib: tighten conditions checked in sock_setfilter
Date: Wed, 4 Jan 2017 16:26:29 -0700 [thread overview]
Message-ID: <3be167c0-b7cb-1ab4-6afe-e2e84a3404f5@kernel.org> (raw)
In-Reply-To: <20170104225554.GD31756@oracle.com>
On 01/04/2017 03:55 PM, Sowmini Varadhan wrote:
> On (01/04/17 15:37), Shuah Khan wrote:
>>> + /* the filter below checks for all of the following conditions that
>>> + * are based on the contents of create_payload()
>>> + * ether type 0x800 and
>>> + * ip proto udp and
>>> + * ip len == ip_len and
>>> + * udp[38] == 'a' or udp[38] == 'b'
>>> + */
>>
>> Looks like you have to do v4 anyway, please make sure your comment
>> block is one of the acceptable formats based on coding style:
>>
>> https://marc.info/?l=linux-crypto-vger&m=146799837129319&w=2
>
> BTW, the above is conformant with the comment style required for
> networking:
>
> https://www.kernel.org/doc/Documentation/networking/netdev-FAQ.txt
>
> which seems to be used in psock_fanout.c and reuseport_bpf.c as well.
I would like to see the comment blocks in selftest consistent with the
Kernel coding style.
>
> Thanks
> --Sowmini
>
Could you please split this patch into two. Hardening part in one and
the cleanup in a separate patch. This way I can get the hardening fix
into 4.10 in my next Kselftest update. Cleanup patch can go in later.
thanks,
-- Shuah
next prev parent reply other threads:[~2017-01-04 23:28 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-04 18:45 [PATCH v3 net-next 0/2] tools: psock_tpacket bug fixes Sowmini Varadhan
2017-01-04 18:45 ` [PATCH v3 net-next 1/2] tools: psock_lib: tighten conditions checked in sock_setfilter Sowmini Varadhan
2017-01-04 22:16 ` Daniel Borkmann
2017-01-04 22:22 ` Sowmini Varadhan
2017-01-04 22:26 ` Daniel Borkmann
2017-01-04 22:48 ` Sowmini Varadhan
2017-01-04 22:59 ` Daniel Borkmann
2017-01-04 22:37 ` Shuah Khan
2017-01-04 22:49 ` Sowmini Varadhan
2017-01-04 22:55 ` Sowmini Varadhan
2017-01-04 23:26 ` Shuah Khan [this message]
2017-01-05 15:54 ` Sowmini Varadhan
2017-01-05 18:46 ` Shuah Khan
2017-01-04 18:45 ` [PATCH v3 net-next 2/2] tools: psock_tpacket: block Rx until socket filter has been added and socket has been bound to loopback Sowmini Varadhan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3be167c0-b7cb-1ab4-6afe-e2e84a3404f5@kernel.org \
--to=shuah@kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sowmini.varadhan@oracle.com \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).