From: Paolo Abeni <pabeni@redhat.com>
To: Pavitra Jha <jhapavitra98@gmail.com>, w@1wt.eu
Cc: chandrashekar.devegowda@intel.com, linux-wwan@lists.linux.dev,
netdev@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH v4] net: wwan: t7xx: validate port_count against message length in t7xx_port_enum_msg_handler
Date: Tue, 21 Apr 2026 10:25:52 +0200 [thread overview]
Message-ID: <3c2f573f-c457-4aec-b929-9e049b4c1d25@redhat.com> (raw)
In-Reply-To: <20260416113205.1789319-1-jhapavitra98@gmail.com>
On 4/16/26 1:32 PM, Pavitra Jha wrote:
> t7xx_port_enum_msg_handler() uses the modem-supplied port_count field as
> a loop bound over port_msg->data[] without checking that the message buffer
> contains sufficient data. A modem sending port_count=65535 in a 12-byte
> buffer triggers a slab-out-of-bounds read of up to 262140 bytes.
>
> Add a struct_size() check after extracting port_count and before the loop.
> Pass msg_len to t7xx_port_enum_msg_handler() and use it to validate
> the message size before accessing port_msg->data[].
> Pass msg_len from both call sites: skb->len at the DPMAIF path after
> skb_pull(), and the captured rt_feature->data_len at the handshake path.
>
> Fixes: 39d439047f1d ("net: wwan: t7xx: Add control DMA interface")
> Cc: stable@vger.kernel.org
> Signed-off-by: Pavitra Jha <jhapavitra98@gmail.com>
Does not apply cleanly to net, patch says:
patching file drivers/net/wwan/t7xx/t7xx_modem_ops.c
patch: **** malformed patch at line 41: return 0;
are you using any https://xkcd.com/378/ derived method to cook your
path? please stick to old good git and verify your local configuration.
/P
next prev parent reply other threads:[~2026-04-21 8:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-11 8:39 [PATCH] net: wwan: t7xx: validate port_count against message length in t7xx_port_enum_msg_handler Pavitra Jha
2026-04-14 9:41 ` Paolo Abeni
2026-04-14 13:17 ` Willy Tarreau
2026-04-14 15:31 ` [PATCH v2] " Pavitra Jha
2026-04-14 16:23 ` Willy Tarreau
2026-04-15 8:47 ` [PATCH v3] " Pavitra Jha
2026-04-16 11:32 ` [PATCH v4] " Pavitra Jha
2026-04-21 8:25 ` Paolo Abeni [this message]
2026-04-15 11:09 ` [PATCH v2] " kernel test robot
2026-04-15 13:37 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3c2f573f-c457-4aec-b929-9e049b4c1d25@redhat.com \
--to=pabeni@redhat.com \
--cc=chandrashekar.devegowda@intel.com \
--cc=jhapavitra98@gmail.com \
--cc=linux-wwan@lists.linux.dev \
--cc=netdev@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=w@1wt.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox