From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ivan Vecera Subject: Re: [PATCH iproute2 2/2] devlink: add batch command support Date: Fri, 10 Nov 2017 08:10:43 +0100 Message-ID: <3c672b8b-d3ca-1d50-c4e1-78a36aae6ed7@redhat.com> References: <20171110062014.2693-1-ivecera@redhat.com> <20171110062014.2693-3-ivecera@redhat.com> <20171110065727.GM18825@mtr-leonro.local> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="pa5XJoHk2MDQFEFEXAEiaD8kPCcL32Tml" Cc: netdev@vger.kernel.org, jiri@mellanox.com, arkadis@mellanox.com To: Leon Romanovsky Return-path: Received: from mx1.redhat.com ([209.132.183.28]:45178 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755260AbdKJHLH (ORCPT ); Fri, 10 Nov 2017 02:11:07 -0500 In-Reply-To: <20171110065727.GM18825@mtr-leonro.local> Sender: netdev-owner@vger.kernel.org List-ID: This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --pa5XJoHk2MDQFEFEXAEiaD8kPCcL32Tml Content-Type: multipart/mixed; boundary="UWrgxCbm2uE5BQmhpRtgJEuaIBTxtr9Pf"; protected-headers="v1" From: Ivan Vecera To: Leon Romanovsky Cc: netdev@vger.kernel.org, jiri@mellanox.com, arkadis@mellanox.com Message-ID: <3c672b8b-d3ca-1d50-c4e1-78a36aae6ed7@redhat.com> Subject: Re: [PATCH iproute2 2/2] devlink: add batch command support References: <20171110062014.2693-1-ivecera@redhat.com> <20171110062014.2693-3-ivecera@redhat.com> <20171110065727.GM18825@mtr-leonro.local> In-Reply-To: <20171110065727.GM18825@mtr-leonro.local> --UWrgxCbm2uE5BQmhpRtgJEuaIBTxtr9Pf Content-Type: text/plain; charset=windows-1252 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 10.11.2017 07:57, Leon Romanovsky wrote: > On Fri, Nov 10, 2017 at 07:20:14AM +0100, Ivan Vecera wrote: >> The patch adds support to batch devlink commands. >> >> Cc: Jiri Pirko >> Cc: Arkadi Sharshevsky >> Signed-off-by: Ivan Vecera >> --- >> devlink/devlink.c | 70 +++++++++++++++++++++++++++++++++++++++++++++= ++------- >> man/man8/devlink.8 | 16 +++++++++++++ >> 2 files changed, 78 insertions(+), 8 deletions(-) >> >=20 > <..> >=20 >> diff --git a/man/man8/devlink.8 b/man/man8/devlink.8 >> index a480766c..a975ef34 100644 >> --- a/man/man8/devlink.8 >> +++ b/man/man8/devlink.8 >> @@ -12,6 +12,12 @@ devlink \- Devlink tool >> .sp >> >> .ti -8 >> +.B devlink >> +.RB "[ " -force " ] " >> +.BI "-batch " filename >> +.sp >> + >> +.ti -8 >> .IR OBJECT " :=3D { " >> .BR dev " | " port " | " monitor " }" >> .sp >> @@ -32,6 +38,16 @@ Print the version of the >> utility and exit. >> >> .TP >> +.BR "\-b", " \-batch " >> +Read commands from provided file or standard input and invoke them. >> +First failure will cause termination of devlink. >=20 > It is worth to document the expected format of that file. > And IMHO, it is better to have ability to load JSON fie which was > generated by -j, instead of declaring new format/knob. It's just a list of command-lines... like other utils (bridge,ip...) I. --UWrgxCbm2uE5BQmhpRtgJEuaIBTxtr9Pf-- --pa5XJoHk2MDQFEFEXAEiaD8kPCcL32Tml Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQJHBAEBCAAxFiEEoTEcTNif3B7aTVHrYAFMrmlSgJkFAloFUQITHGl2ZWNlcmFA cmVkaGF0LmNvbQAKCRBgAUyuaVKAmV+fD/9O+5F3yfLlYDEWMB/QCbX7DfjKNqRe aguxk+cmqteH8PYM4AaKHYPUAlFCslwKmmqCTg855EiFqFBgJ6A0dtrV4mNbSY6r 0qz2jvDpQAWuPIIr/HW4lQQz3vQMJec6Dzf6ASSZ6mo71dTswhdZuzvlfMqvEdSN WRA0BDhGv9GieZ/SfmoeL+YsvkTCLgoh67SKx2IT/P5IM3h6UN/M4b8sucA5Dlu6 tcXyw7xWvV02iHuvLEBPtKrfgG/0+EzWwcLeTdr0y288Ih4vDSUSxouPj0atGcJ8 aOVwoRCJHCHgkUhti3r//tXf3GjC4LUwmxuE2ap4G0v5UVoxj0ojf1oFLtTp1C8a 0MyMD5/8aWeb5d5u7UwbmIJ6Bfx4fwli9M1CUJAzk6fU7Brftqd6YQzPuRnDS50X FlXFBfBmUAwBmJDyyAAUKV2GCdJd6jO+DgKdWI8Vj4ubI3iyxtq8hQD9Xx65KtUL Pv7wqLqovl0/92QMwbDt3J6G1sd7hEN4VF92/7QtjpR9no6LgHzMCnkVs6gORonF lF4DxfX+O2jT9Tm8ZPc0XTpiIXgBeuuYUW8nnmbhPiI2yJVH1a4xqSu8DGvD2OEv 83nONJBImgu8loIrhRWXeBHGPjApkrKxXcQL+HjRP0UibuDjAJ71xgUMyyDnGmfK 0X2Lc57VFyqZUg== =PupJ -----END PGP SIGNATURE----- --pa5XJoHk2MDQFEFEXAEiaD8kPCcL32Tml--