Re: [PATCH net-next v5 09/11] net: wangxun: add Tx timeout process

[Paolo Abeni <pabeni@redhat.com>]

On 3/17/26 8:38 AM, Jiawen Wu wrote:
> +bool wx_check_tx_hang(struct wx_ring *ring)
> +{
> +	u64 tx_done_old = ring->tx_stats.tx_done_old;
> +	u64 tx_pending = wx_get_tx_pending(ring);
> +	u64 tx_done = ring->stats.packets;
> +
> +	clear_bit(WX_TX_DETECT_HANG, ring->state);
> +
> +	/*
> +	 * Check for a hung queue, but be thorough. This verifies
> +	 * that a transmit has been completed since the previous
> +	 * check AND there is at least one packet pending. The
> +	 * ARMED bit is set to indicate a potential hang. The
> +	 * bit is cleared if a pause frame is received to remove

AFAICS this is handled in patch 11, at slot reset time, which IIRC is
quite separate from pause frame reception.

I think this comment need to be update to reflect the current behavior.
Also you should explicitly mention in the commit message that the actual
implementation of this part will with a later patch.

/P