From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9120BC282C5 for ; Thu, 24 Jan 2019 20:10:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 49FC6218A6 for ; Thu, 24 Jan 2019 20:10:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="dksx3mAH" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729697AbfAXUKH (ORCPT ); Thu, 24 Jan 2019 15:10:07 -0500 Received: from mail-yb1-f195.google.com ([209.85.219.195]:46237 "EHLO mail-yb1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730153AbfAXT2F (ORCPT ); Thu, 24 Jan 2019 14:28:05 -0500 Received: by mail-yb1-f195.google.com with SMTP id y7so2827601ybg.13 for ; Thu, 24 Jan 2019 11:28:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:openpgp:autocrypt:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Q5QC/DVwo1Tx1egj4ffLGQTw1I7BwJpgbh8AZBboKfE=; b=dksx3mAH8C92fomXv4Ac+J4ngkXcDhsJiKm642EQqhpenNfobtP4Afx6D8LfGepVxn itaPldv64FUisr9mLy6aAsGwT34Pibu55lzaSUeEP+nQRkxCq6u/xExiTQWU/B9RNgMT jUefN9k+JpagFzgLndt+FCTP/WWlVGqTjhFAxzoDGPXPJFcg3qxxuUlLqpP2flRYc8lF KdoQGYjZwLBowNQ/x4iN5xmVioBnRToF4vkIuRD683pm5mVxwNLrpcES2OkAxWyejTk6 NzKMelFC7gsZqmLTzgdUZb1JlCXmIi/3lEXCSr61v3eclU6mRhcBTriU5+dMpdbrHwfd LBEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:openpgp:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=Q5QC/DVwo1Tx1egj4ffLGQTw1I7BwJpgbh8AZBboKfE=; b=BNlGhFMLkjSHXtpeqVjaXhx1iXm6cPtLaezoLaDh7Uz1iuxSgMPNNWS/Q9K2TmJfso aeel0wEyOvG472WgvivNBYI7uxw51JgUyCwQ4lrUuVw8NALG9uJCBtgE3t1u0BYyADvX 6fe9TYftigwK9B7ptMC2gCRtbgxHKmhWhxgel9EzO75aujcrak5pQlKFcw9NoadM8gr6 lVaTgYtSEoZt0i5adr6FsGQ8oqdpOQf7gg5x0lPKxQ+IspR7qB45QzCjY4kQWcOiHtuL uQMPtLWeu7/e8FU4oFyKz/91jJZddwrEfEH8C8f61pR/0bef1+b8HDZUKkgdfUs7FhBZ +dig== X-Gm-Message-State: AJcUukc0v1CKxuSYzfMBnp46gmGMX4ItJp1qD6FzqkCWXNGAjWNbIxq+ BeVoK3hSfZsIE60eHKfKMQV6w1Xq X-Google-Smtp-Source: ALg8bN4af2hbC1XJKJu2rUzvPsTw4it6gXR4DpQMKSsrL291SdC8Uy31HVYgAvHnr9eV37yYty6DVQ== X-Received: by 2002:a25:2485:: with SMTP id k127mr7456607ybk.89.1548358084036; Thu, 24 Jan 2019 11:28:04 -0800 (PST) Received: from [10.67.49.9] ([192.19.223.250]) by smtp.googlemail.com with ESMTPSA id z37sm10948913ywj.3.2019.01.24.11.28.01 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 24 Jan 2019 11:28:03 -0800 (PST) Subject: Re: [PATCH net-next v1 1/2] net: dsa: mv88e6xxx: Default CMODE to 1000BaseX only on 6390X To: Marek Behun , Andrew Lunn Cc: netdev@vger.kernel.org, David Miller References: <20190124154309.24987-1-marek.behun@nic.cz> <20190124161147.GG482@lunn.ch> <20190124172916.66e15b29@nic.cz> <20190124164805.GJ482@lunn.ch> <20190124190451.40af3127@nic.cz> <20190124181159.GL482@lunn.ch> <20190124202403.0d15ec6f@nic.cz> From: Florian Fainelli Openpgp: preference=signencrypt Autocrypt: addr=f.fainelli@gmail.com; prefer-encrypt=mutual; keydata= mQGiBEjPuBIRBACW9MxSJU9fvEOCTnRNqG/13rAGsj+vJqontvoDSNxRgmafP8d3nesnqPyR xGlkaOSDuu09rxuW+69Y2f1TzjFuGpBk4ysWOR85O2Nx8AJ6fYGCoeTbovrNlGT1M9obSFGQ X3IzRnWoqlfudjTO5TKoqkbOgpYqIo5n1QbEjCCwCwCg3DOH/4ug2AUUlcIT9/l3pGvoRJ0E AICDzi3l7pmC5IWn2n1mvP5247urtHFs/uusE827DDj3K8Upn2vYiOFMBhGsxAk6YKV6IP0d ZdWX6fqkJJlu9cSDvWtO1hXeHIfQIE/xcqvlRH783KrihLcsmnBqOiS6rJDO2x1eAgC8meAX SAgsrBhcgGl2Rl5gh/jkeA5ykwbxA/9u1eEuL70Qzt5APJmqVXR+kWvrqdBVPoUNy/tQ8mYc nzJJ63ng3tHhnwHXZOu8hL4nqwlYHRa9eeglXYhBqja4ZvIvCEqSmEukfivk+DlIgVoOAJbh qIWgvr3SIEuR6ayY3f5j0f2ejUMYlYYnKdiHXFlF9uXm1ELrb0YX4GMHz7QnRmxvcmlhbiBG YWluZWxsaSA8Zi5mYWluZWxsaUBnbWFpbC5jb20+iGYEExECACYCGyMGCwkIBwMCBBUCCAME FgIDAQIeAQIXgAUCVF/S8QUJHlwd3wAKCRBhV5kVtWN2DvCVAJ4u4/bPF4P3jxb4qEY8I2gS 6hG0gACffNWlqJ2T4wSSn+3o7CCZNd7SLSC5BA0ESM+4EhAQAL/o09boR9D3Vk1Tt7+gpYr3 WQ6hgYVON905q2ndEoA2J0dQxJNRw3snabHDDzQBAcqOvdi7YidfBVdKi0wxHhSuRBfuOppu pdXkb7zxuPQuSveCLqqZWRQ+Cc2QgF7SBqgznbe6Ngout5qXY5Dcagk9LqFNGhJQzUGHAsIs hap1f0B1PoUyUNeEInV98D8Xd/edM3mhO9nRpUXRK9Bvt4iEZUXGuVtZLT52nK6Wv2EZ1TiT OiqZlf1P+vxYLBx9eKmabPdm3yjalhY8yr1S1vL0gSA/C6W1o/TowdieF1rWN/MYHlkpyj9c Rpc281gAO0AP3V1G00YzBEdYyi0gaJbCEQnq8Vz1vDXFxHzyhgGz7umBsVKmYwZgA8DrrB0M oaP35wuGR3RJcaG30AnJpEDkBYHznI2apxdcuTPOHZyEilIRrBGzDwGtAhldzlBoBwE3Z3MY 31TOpACu1ZpNOMysZ6xiE35pWkwc0KYm4hJA5GFfmWSN6DniimW3pmdDIiw4Ifcx8b3mFrRO BbDIW13E51j9RjbO/nAaK9ndZ5LRO1B/8Fwat7bLzmsCiEXOJY7NNpIEpkoNoEUfCcZwmLrU +eOTPzaF6drw6ayewEi5yzPg3TAT6FV3oBsNg3xlwU0gPK3v6gYPX5w9+ovPZ1/qqNfOrbsE FRuiSVsZQ5s3AAMFD/9XjlnnVDh9GX/r/6hjmr4U9tEsM+VQXaVXqZuHKaSmojOLUCP/YVQo 7IiYaNssCS4FCPe4yrL4FJJfJAsbeyDykMN7wAnBcOkbZ9BPJPNCbqU6dowLOiy8AuTYQ48m vIyQ4Ijnb6GTrtxIUDQeOBNuQC/gyyx3nbL/lVlHbxr4tb6YkhkO6shjXhQh7nQb33FjGO4P WU11Nr9i/qoV8QCo12MQEo244RRA6VMud06y/E449rWZFSTwGqb0FS0seTcYNvxt8PB2izX+ HZA8SL54j479ubxhfuoTu5nXdtFYFj5Lj5x34LKPx7MpgAmj0H7SDhpFWF2FzcC1bjiW9mjW HaKaX23Awt97AqQZXegbfkJwX2Y53ufq8Np3e1542lh3/mpiGSilCsaTahEGrHK+lIusl6mz Joil+u3k01ofvJMK0ZdzGUZ/aPMZ16LofjFA+MNxWrZFrkYmiGdv+LG45zSlZyIvzSiG2lKy kuVag+IijCIom78P9jRtB1q1Q5lwZp2TLAJlz92DmFwBg1hyFzwDADjZ2nrDxKUiybXIgZp9 aU2d++ptEGCVJOfEW4qpWCCLPbOT7XBr+g/4H3qWbs3j/cDDq7LuVYIe+wchy/iXEJaQVeTC y5arMQorqTFWlEOgRA8OP47L9knl9i4xuR0euV6DChDrguup2aJVU4hPBBgRAgAPAhsMBQJU X9LxBQkeXB3fAAoJEGFXmRW1Y3YOj4UAn3nrFLPZekMeqX5aD/aq/dsbXSfyAKC45Go0YyxV HGuUuzv+GKZ6nsysJ7kCDQRXG8fwARAA6q/pqBi5PjHcOAUgk2/2LR5LjjesK50bCaD4JuNc YDhFR7Vs108diBtsho3w8WRd9viOqDrhLJTroVckkk74OY8r+3t1E0Dd4wHWHQZsAeUvOwDM PQMqTUBFuMi6ydzTZpFA2wBR9x6ofl8Ax+zaGBcFrRlQnhsuXLnM1uuvS39+pmzIjasZBP2H UPk5ifigXcpelKmj6iskP3c8QN6x6GjUSmYx+xUfs/GNVSU1XOZn61wgPDbgINJd/THGdqiO iJxCLuTMqlSsmh1+E1dSdfYkCb93R/0ZHvMKWlAx7MnaFgBfsG8FqNtZu3PCLfizyVYYjXbV WO1A23riZKqwrSJAATo5iTS65BuYxrFsFNPrf7TitM8E76BEBZk0OZBvZxMuOs6Z1qI8YKVK UrHVGFq3NbuPWCdRul9SX3VfOunr9Gv0GABnJ0ET+K7nspax0xqq7zgnM71QEaiaH17IFYGS sG34V7Wo3vyQzsk7qLf9Ajno0DhJ+VX43g8+AjxOMNVrGCt9RNXSBVpyv2AMTlWCdJ5KI6V4 KEzWM4HJm7QlNKE6RPoBxJVbSQLPd9St3h7mxLcne4l7NK9eNgNnneT7QZL8fL//s9K8Ns1W t60uQNYvbhKDG7+/yLcmJgjF74XkGvxCmTA1rW2bsUriM533nG9gAOUFQjURkwI8jvMAEQEA AYkCaAQYEQIACQUCVxvH8AIbAgIpCRBhV5kVtWN2DsFdIAQZAQIABgUCVxvH8AAKCRCH0Jac RAcHBIkHD/9nmfog7X2ZXMzL9ktT++7x+W/QBrSTCTmq8PK+69+INN1ZDOrY8uz6htfTLV9+ e2W6G8/7zIvODuHk7r+yQ585XbplgP0V5Xc8iBHdBgXbqnY5zBrcH+Q/oQ2STalEvaGHqNoD UGyLQ/fiKoLZTPMur57Fy1c9rTuKiSdMgnT0FPfWVDfpR2Ds0gpqWePlRuRGOoCln5GnREA/ 2MW2rWf+CO9kbIR+66j8b4RUJqIK3dWn9xbENh/aqxfonGTCZQ2zC4sLd25DQA4w1itPo+f5 V/SQxuhnlQkTOCdJ7b/mby/pNRz1lsLkjnXueLILj7gNjwTabZXYtL16z24qkDTI1x3g98R/ xunb3/fQwR8FY5/zRvXJq5us/nLvIvOmVwZFkwXc+AF+LSIajqQz9XbXeIP/BDjlBNXRZNdo dVuSU51ENcMcilPr2EUnqEAqeczsCGpnvRCLfVQeSZr2L9N4svNhhfPOEscYhhpHTh0VPyxI pPBNKq+byuYPMyk3nj814NKhImK0O4gTyCK9b+gZAVvQcYAXvSouCnTZeJRrNHJFTgTgu6E0 caxTGgc5zzQHeX67eMzrGomG3ZnIxmd1sAbgvJUDaD2GrYlulfwGWwWyTNbWRvMighVdPkSF 6XFgQaosWxkV0OELLy2N485YrTr2Uq64VKyxpncLh50e2RnyAJ9Za0Dx0yyp44iD1OvHtkEI M5kY0ACeNhCZJvZ5g4C2Lc9fcTHu8jxmEkI= Message-ID: <3c81ed78-4f0e-37b1-710c-6d96c3e76577@gmail.com> Date: Thu, 24 Jan 2019 11:27:54 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <20190124202403.0d15ec6f@nic.cz> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 1/24/19 11:24 AM, Marek Behun wrote: > On Thu, 24 Jan 2019 19:11:59 +0100 > Andrew Lunn wrote: > >> On Thu, Jan 24, 2019 at 07:04:51PM +0100, Marek Behun wrote: >>> What properties does the cpu port node need to contain to force it? >>> phy-mode = "2500base-x"; is not enough. >> >> Hi Marek >> >> For DSA ports we have: >> >> phy-mode = >> "rgmii-txid"; fixed-link { >> speed = >> <1000>; full-duplex; >> }; >> >> See dsa_port_fixed_link_register_of() >> >> Andrew > > Hi Andrew, > the configuration > phy-mode = "2500base-x"; > fixed-link { > speed = <2500>; > full-duplex; > }; > does not work, because swphy does not support speed=2500 (only 10, 100 > and 1000). > managed = "in-band-status"; > does not work either. > > If I use speed = <1000>, then the swphy is created correctly, cmode is > set correctly to 2500base-x, but speed register on the port is set to > 1000, and the connection does not work. > > The easiest way would probably be to implement swphy to support speed > 2500. But I don't know what values should the simulated PHY registers > contain... > > The function dsa_port_fixed_link_register_of creates this phy device, > adjusts the link and then calls put_device(&phydev->mdio.dev); > Does this mean that the phy device is immediately destroyed? Yes, we should actually migrate that code over to PHYLINK, because in PHYLINK the fixed links don't require creating a phy_device instance. This is something that has a potential of breaking a lot of people, so I have not really started doing it just yet :) -- Florian