From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpout-02.galae.net (smtpout-02.galae.net [185.246.84.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2645B48A2DD for ; Wed, 13 May 2026 12:49:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.246.84.56 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778676587; cv=none; b=uI2KLyMAuczJgM0kKeJ50Q6jRiimeycVq55T+o5C5sypScR9a8Nyaabzz95MYa9VGB355JScIkHLpHGxiD+W5bjysa6LhfvrNVBtPNSJ8CNmBeVUKaXwDvS0xlgE8uPmDyjOcb7dAB4S5S5OwxVFmnebA4RWWyMjTXwat39Pkv4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778676587; c=relaxed/simple; bh=CfNcVj10qBM9P9PLyzMgngcL8HLdsqCqIUisDHfByCc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=iKcl2Tb4mm2oQJWVHHEKRewqOzXihEopLgnnaq9Rf3JjAjoIZ3FGoiJ2hWYQ3OK9eL6/wx3nrGpKNdFSPBJGNwvBmG3bE2sLXGfK/YSeel8O6GFGFNu9sst8Iuk5F8t44lAiirKGN7Eqwbb9PUMHSyGSNnSQOwSZFhEwr0BdOx4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=sgVlDKOd; arc=none smtp.client-ip=185.246.84.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="sgVlDKOd" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-02.galae.net (Postfix) with ESMTPS id 917371A3592; Wed, 13 May 2026 12:49:42 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id 636855FE21; Wed, 13 May 2026 12:49:42 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 2CA8A11AF9021; Wed, 13 May 2026 14:49:33 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1778676581; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:content-language:in-reply-to:references; bh=RtgLHFuD2Bclv96Rf+7+3DMG5yroMjMm+9TZ0Z3c6RY=; b=sgVlDKOdp65Wsq8xbOV2LpNP1xjlUt1OUDJmNcahu2ETny/h1e9ju9EmoDvkugwEsphpBU 6jyIPCFFrm/7atPQrUH0ofwNnObeg/WAflYnbtyFCwfVFrGp1MVx86MbxKlfARkO1UyEhs IMJzkhzlZ5jSPZ8ESzRZj+nxnAB8q1V3SUq2WxxCDB8UJD3/f6t6OVcuYw9OMng/1fFIvS P3aeXpdtyAVzQ9fPOI9D70ZIY/otIeCL0RctoRVUMQZzKcYSFQJVabp9H9JBl23AvFSyy6 VWUeuX6eEXHBJvMIC0xk3VmgS5B97IkoxDBgWVtWjyMFB2f3qmtUmAopoO2T+A== Message-ID: <3c8c7d5e-9f21-4a2b-aec3-d79d68559e42@bootlin.com> Date: Wed, 13 May 2026 14:49:32 +0200 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next v9 03/10] net: phylink: Register a phy_port for MAC-driven SFP busses To: Andrew Lunn Cc: davem@davemloft.net, Jakub Kicinski , Eric Dumazet , Paolo Abeni , Russell King , Heiner Kallweit , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, thomas.petazzoni@bootlin.com, Christophe Leroy , Herve Codina , Florian Fainelli , Vladimir Oltean , =?UTF-8?Q?K=C3=B6ry_Maincent?= , =?UTF-8?Q?Marek_Beh=C3=BAn?= , Oleksij Rempel , =?UTF-8?Q?Nicol=C3=B2_Veronese?= , Simon Horman , mwojtas@chromium.org, Romain Gantois , Daniel Golle , Dimitri Fedrau References: <20260403123755.175742-1-maxime.chevallier@bootlin.com> <20260403123755.175742-4-maxime.chevallier@bootlin.com> <7838a71b-ae3a-4681-8516-c450ea8a5321@lunn.ch> Content-Language: en-US From: Maxime Chevallier In-Reply-To: <7838a71b-ae3a-4681-8516-c450ea8a5321@lunn.ch> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Last-TLS-Session-Version: TLSv1.3 Hi Andrew, On 4/15/26 01:38, Andrew Lunn wrote: >> This phy_port represents the SFP cage itself, and not the module > >> +static int phylink_create_sfp_port(struct phylink *pl) > > I'm thinking about naming here. If this represent the cage, why not > call this phylink_create_sfp_cage_port(). I assume as some point there > is going to be something for the module, and it seem like the naming > is going to be confusing. > >> +{ >> + struct phy_port *port; >> + int ret = 0; >> + >> + if (!pl->netdev || !pl->sfp_bus) >> + return 0; >> + >> + port = phy_port_alloc(); >> + if (!port) >> + return -ENOMEM; >> + >> + port->is_sfp = true; >> + port->is_mii = true; >> + port->active = true; > > If this is a cage, not a module, does is_sfp = true make sense? > > And what does an active cage mean? My bad I realised that I forgot to reply to this comment :( So, is_sfp is meant for sfp cages, I'll followup with some documentation update. Active means we want this port to be used. For now, every port we represent is active. The next step for that work will implement the muxing and port switchover logic, where the active ports will represent the ones that actually got the link. For now, we don't have the logic to expose and use that. In retrospect, It's something that should've been added in later steps. Maxime > > Andrew