From: "Arinzon, David" <darinzon@amazon.com>
To: Joe Damato <jdamato@fastly.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Cc: "Kiyanovski, Arthur" <akiyano@amazon.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Kamal Heib <kheib@redhat.com>,
open list <linux-kernel@vger.kernel.org>,
"Dagan, Noam" <ndagan@amazon.com>,
"Paolo Abeni" <pabeni@redhat.com>,
"Bshara, Saeed" <saeedb@amazon.com>,
"Agroskin, Shay" <shayagr@amazon.com>
Subject: RE: [net-next v2 0/2] ena: Link IRQs, queues, and NAPI instances
Date: Wed, 2 Oct 2024 06:28:48 +0000 [thread overview]
Message-ID: <3ca2ee862356426e84b840db94496581@amazon.com> (raw)
In-Reply-To: <20241002001331.65444-1-jdamato@fastly.com>
> Greetings:
>
> Welcome to v2. This includes only cosmetic changes, see changelog below
> and in each patch.
>
> This series uses the netdev-genl API to link IRQs and queues to NAPI IDs so
> that this information is queryable by user apps. This is particularly useful for
> epoll-based busy polling apps which rely on having access to the NAPI ID.
>
> I've tested these commits on an EC2 instance with an ENA NIC configured
> and have included test output in the commit messages for each patch
> showing how to query the information.
>
> I noted in the implementation that the driver requests an IRQ for
> management purposes which does not have an associated NAPI. I tried to
> take this into account in patch 1, but would appreciate if ENA maintainers can
> verify I did this correctly.
>
> Thanks,
> Joe
>
> v2:
> - Preserve reverse christmas tree ordering in patch 1
> - Add comment that the API is for non-XDP queues only to patch 2
>
> v1:
> - https://lore.kernel.org/all/20240930195617.37369-1-jdamato@fastly.com/
>
> Joe Damato (2):
> ena: Link IRQs to NAPI instances
> ena: Link queues to NAPIs
>
> drivers/net/ethernet/amazon/ena/ena_netdev.c | 40
> +++++++++++++++++---
> 1 file changed, 35 insertions(+), 5 deletions(-)
>
> --
> 2.25.1
Thanks!
Reviewed-by: David Arinzon <darinzon@amazon.com>
next prev parent reply other threads:[~2024-10-02 6:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-02 0:13 [net-next v2 0/2] ena: Link IRQs, queues, and NAPI instances Joe Damato
2024-10-02 0:13 ` [net-next v2 1/2] ena: Link IRQs to " Joe Damato
2024-10-02 6:27 ` Arinzon, David
2024-10-02 0:13 ` [net-next v2 2/2] ena: Link queues to NAPIs Joe Damato
2024-10-02 6:28 ` Arinzon, David
2024-10-02 6:28 ` Arinzon, David [this message]
2024-10-03 23:20 ` [net-next v2 0/2] ena: Link IRQs, queues, and NAPI instances patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3ca2ee862356426e84b840db94496581@amazon.com \
--to=darinzon@amazon.com \
--cc=akiyano@amazon.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jdamato@fastly.com \
--cc=kheib@redhat.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ndagan@amazon.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=saeedb@amazon.com \
--cc=shayagr@amazon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).