From: David Ahern <dsahern@gmail.com>
To: Stephen Hemminger <stephen@networkplumber.org>, davem@davemloft.net
Cc: netdev@vger.kernel.org, Stephen Hemminger <sthemmin@microsoft.com>
Subject: Re: [PATCH net-next 2/2] veth: set peer GSO values
Date: Sat, 9 Dec 2017 09:41:25 -0700 [thread overview]
Message-ID: <3cc96c83-846d-7441-99b1-79947ca9fcd6@gmail.com> (raw)
In-Reply-To: <20171207234020.18783-3-sthemmin@microsoft.com>
On 12/7/17 4:40 PM, Stephen Hemminger wrote:
> diff --git a/drivers/net/veth.c b/drivers/net/veth.c
> index f5438d0978ca..a69ad39ee57e 100644
> --- a/drivers/net/veth.c
> +++ b/drivers/net/veth.c
> @@ -410,6 +410,9 @@ static int veth_newlink(struct net *src_net, struct net_device *dev,
> if (ifmp && (dev->ifindex != 0))
> peer->ifindex = ifmp->ifi_index;
>
> + peer->gso_max_size = dev->gso_max_size;
> + peer->gso_max_segs = dev->gso_max_segs;
> +
> err = register_netdevice(peer);
> put_net(net);
> net = NULL;
>
What if gso changes are made after device create? They are not
propagated to the peer device like they are on link create.
next prev parent reply other threads:[~2017-12-09 16:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-07 23:40 [PATCH net-next v3 0/2] veth and GSO maximums Stephen Hemminger
2017-12-07 23:40 ` [PATCH net-next 1/2] rtnetlink: allow GSO maximums to be set on device creation Stephen Hemminger
2017-12-07 23:40 ` [PATCH net-next 2/2] veth: set peer GSO values Stephen Hemminger
2017-12-09 16:41 ` David Ahern [this message]
2017-12-09 19:51 ` Solio Sarabia
2017-12-08 19:23 ` [PATCH net-next v3 0/2] veth and GSO maximums David Miller
2017-12-08 23:50 ` Solio Sarabia
2017-12-09 0:15 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3cc96c83-846d-7441-99b1-79947ca9fcd6@gmail.com \
--to=dsahern@gmail.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
--cc=sthemmin@microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).