From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Ahern Subject: Re: [PATCH net-next 2/2] veth: set peer GSO values Date: Sat, 9 Dec 2017 09:41:25 -0700 Message-ID: <3cc96c83-846d-7441-99b1-79947ca9fcd6@gmail.com> References: <20171207234020.18783-1-sthemmin@microsoft.com> <20171207234020.18783-3-sthemmin@microsoft.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, Stephen Hemminger To: Stephen Hemminger , davem@davemloft.net Return-path: Received: from mail-pf0-f196.google.com ([209.85.192.196]:38208 "EHLO mail-pf0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750947AbdLIQl1 (ORCPT ); Sat, 9 Dec 2017 11:41:27 -0500 Received: by mail-pf0-f196.google.com with SMTP id u25so9045226pfg.5 for ; Sat, 09 Dec 2017 08:41:26 -0800 (PST) In-Reply-To: <20171207234020.18783-3-sthemmin@microsoft.com> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 12/7/17 4:40 PM, Stephen Hemminger wrote: > diff --git a/drivers/net/veth.c b/drivers/net/veth.c > index f5438d0978ca..a69ad39ee57e 100644 > --- a/drivers/net/veth.c > +++ b/drivers/net/veth.c > @@ -410,6 +410,9 @@ static int veth_newlink(struct net *src_net, struct net_device *dev, > if (ifmp && (dev->ifindex != 0)) > peer->ifindex = ifmp->ifi_index; > > + peer->gso_max_size = dev->gso_max_size; > + peer->gso_max_segs = dev->gso_max_segs; > + > err = register_netdevice(peer); > put_net(net); > net = NULL; > What if gso changes are made after device create? They are not propagated to the peer device like they are on link create.