From: Paolo Abeni <pabeni@redhat.com>
To: Pablo Neira Ayuso <pablo@netfilter.org>, netfilter-devel@vger.kernel.org
Cc: davem@davemloft.net, netdev@vger.kernel.org, kuba@kernel.org,
edumazet@google.com, fw@strlen.de
Subject: Re: [PATCH net 4/5] selftests: add selftest for the SRv6 End.DX4 behavior with netfilter
Date: Thu, 20 Jun 2024 11:40:30 +0200 [thread overview]
Message-ID: <3d0635da6ea9b3a6445c5e6751ec0cfd024a08e1.camel@redhat.com> (raw)
In-Reply-To: <20240619170537.2846-5-pablo@netfilter.org>
On Wed, 2024-06-19 at 19:05 +0200, Pablo Neira Ayuso wrote:
> +setup_hs()
> +{
> + local hs=$1
> + local rt=$2
> + local tid=$3
> + local hsname=hs-${hs}
> + local rtname=rt-${rt}
> + local rtveth=veth-t${tid}
> +
> + # set the networking for the host
> + ip netns add ${hsname}
Side note for a possible follow-up (_not_ intended to block this
PR!!!):
If you leverage setup_ns() from lib.sh, you can reduce a bit the code
duplication, and the script will avoid any possible netns name
conflict.
The same for the following test.
Cheers,
Paolo
next prev parent reply other threads:[~2024-06-20 9:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-19 17:05 [PATCH net 0/5] Netfilter fixes for net Pablo Neira Ayuso
2024-06-19 17:05 ` [PATCH net 1/5] netfilter: ipset: Fix suspicious rcu_dereference_protected() Pablo Neira Ayuso
2024-06-20 9:50 ` patchwork-bot+netdevbpf
2024-06-19 17:05 ` [PATCH net 2/5] seg6: fix parameter passing when calling NF_HOOK() in End.DX4 and End.DX6 behaviors Pablo Neira Ayuso
2024-06-19 17:05 ` [PATCH net 3/5] netfilter: move the sysctl nf_hooks_lwtunnel into the netfilter core Pablo Neira Ayuso
2024-06-19 17:05 ` [PATCH net 4/5] selftests: add selftest for the SRv6 End.DX4 behavior with netfilter Pablo Neira Ayuso
2024-06-20 9:40 ` Paolo Abeni [this message]
2024-06-19 17:05 ` [PATCH net 5/5] selftests: add selftest for the SRv6 End.DX6 " Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3d0635da6ea9b3a6445c5e6751ec0cfd024a08e1.camel@redhat.com \
--to=pabeni@redhat.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=fw@strlen.de \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).