Re: [PATCH net-next v2] net: bonding: add bond_is_icmpv6_nd() helper

[Paolo Abeni <pabeni@redhat.com>]

On 7/14/25 2:53 PM, Tonghao Zhang wrote:
>> 2025年7月14日 15:13，Hangbin Liu <liuhangbin@gmail.com> 写道：
>> Hmm, I don’t see much improvement with this patch compared to without it.
>> So I don’t think this update is necessary.
> 
> This patch use the skb_header_pointer instead of pskb_network_may_pull. The skb_header_pointer is more efficient than pskb_network_may_pull.
>  And use the comm helper can consolidate some duplicate code.

I think the eventual cleanup here is very subjective, especially
compared to the diffstat. Any eventual performance improvement should be
supported by some figures, in relevant tests.

In this specific case I don't think you will be able to measure any
relevant gain; pskb_network_may_pull() could be slower than
skb_header_pointer() only when the headers are not in the liner part,
and that in turns could happen only if we are already on some kind of
slow path.

/P