From: "Neftin, Sasha" <sasha.neftin@intel.com>
To: Jakub Kicinski <jakub.kicinski@netronome.com>,
Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org, nhorman@redhat.com,
sassmann@redhat.com, "Neftin, Sasha" <sasha.neftin@intel.com>
Subject: Re: [net-next 03/11] igc: Add netdev
Date: Wed, 24 Oct 2018 14:43:25 +0300 [thread overview]
Message-ID: <3d4b0570-6ef4-442b-e2cf-5b7a9c47e226@intel.com> (raw)
In-Reply-To: <20181018101512.25588895@cakuba.netronome.com>
On 10/18/2018 20:15, Jakub Kicinski wrote:
> On Wed, 17 Oct 2018 15:23:14 -0700, Jeff Kirsher wrote:
>> +/**
>> + * igc_ioctl - I/O control method
>> + * @netdev: network interface device structure
>> + * @ifreq: frequency
>
> Is it? :)
>
Ah... Good catch. I will fix that and submit patch.
>> + * @cmd: command
>> + */
>> +static int igc_ioctl(struct net_device *netdev, struct ifreq *ifr, int cmd)
>> +{
>> + switch (cmd) {
>> + default:
>> + return -EOPNOTSUPP;
>> + }
>> +}
>
> You don't seem to be adding anything to this function in the series.
> Why add the stub?
>
Right. Still not in use. I will remove and add per demand.
Thanks for your comments.
next prev parent reply other threads:[~2018-10-24 20:11 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-17 22:23 [net-next 00/11][pull request] 1GbE Intel Wired LAN Driver Updates 2018-10-17 Jeff Kirsher
2018-10-17 22:23 ` [net-next 01/11] igc: Add skeletal frame for Intel(R) 2.5G Ethernet Controller support Jeff Kirsher
2018-10-18 17:14 ` Jakub Kicinski
2018-10-24 8:50 ` Neftin, Sasha
2018-10-17 22:23 ` [net-next 02/11] igc: Add support for PF Jeff Kirsher
2018-10-17 22:23 ` [net-next 03/11] igc: Add netdev Jeff Kirsher
2018-10-18 17:15 ` Jakub Kicinski
2018-10-24 11:43 ` Neftin, Sasha [this message]
2018-10-17 22:23 ` [net-next 04/11] igc: Add interrupt support Jeff Kirsher
2018-10-17 22:23 ` [net-next 05/11] igc: Add support for Tx/Rx rings Jeff Kirsher
2018-10-17 22:23 ` [net-next 06/11] igc: Add transmit and receive fastpath and interrupt handlers Jeff Kirsher
2018-10-17 22:23 ` [net-next 07/11] igc: Add HW initialization code Jeff Kirsher
2018-10-17 22:23 ` [net-next 08/11] igc: Add NVM support Jeff Kirsher
2018-10-17 22:23 ` [net-next 09/11] igc: Add code for PHY support Jeff Kirsher
2018-10-17 22:23 ` [net-next 10/11] igc: Add setup link functionality Jeff Kirsher
2018-10-17 22:23 ` [net-next 11/11] igc: Add watchdog Jeff Kirsher
2018-10-18 17:27 ` [net-next 00/11][pull request] 1GbE Intel Wired LAN Driver Updates 2018-10-17 David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3d4b0570-6ef4-442b-e2cf-5b7a9c47e226@intel.com \
--to=sasha.neftin@intel.com \
--cc=davem@davemloft.net \
--cc=jakub.kicinski@netronome.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=netdev@vger.kernel.org \
--cc=nhorman@redhat.com \
--cc=sassmann@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).