From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Neftin, Sasha" <sasha.neftin@intel.com>
Subject: Re: [net-next 03/11] igc: Add netdev
Date: Wed, 24 Oct 2018 14:43:25 +0300
Message-ID: <3d4b0570-6ef4-442b-e2cf-5b7a9c47e226@intel.com>
References: <20181017222322.2171-1-jeffrey.t.kirsher@intel.com>
 <20181017222322.2171-4-jeffrey.t.kirsher@intel.com>
 <20181018101512.25588895@cakuba.netronome.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Cc: davem@davemloft.net, netdev@vger.kernel.org, nhorman@redhat.com,
        sassmann@redhat.com, "Neftin, Sasha" <sasha.neftin@intel.com>
To: Jakub Kicinski <jakub.kicinski@netronome.com>,
        Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mga05.intel.com ([192.55.52.43]:63838 "EHLO mga05.intel.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1726964AbeJXULQ (ORCPT <rfc822;netdev@vger.kernel.org>);
        Wed, 24 Oct 2018 16:11:16 -0400
In-Reply-To: <20181018101512.25588895@cakuba.netronome.com>
Content-Language: en-US
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On 10/18/2018 20:15, Jakub Kicinski wrote:
> On Wed, 17 Oct 2018 15:23:14 -0700, Jeff Kirsher wrote:
>> +/**
>> + * igc_ioctl - I/O control method
>> + * @netdev: network interface device structure
>> + * @ifreq: frequency
> 
> Is it? :)
> 
Ah... Good catch. I will fix that and submit patch.
>> + * @cmd: command
>> + */
>> +static int igc_ioctl(struct net_device *netdev, struct ifreq *ifr, int cmd)
>> +{
>> +	switch (cmd) {
>> +	default:
>> +		return -EOPNOTSUPP;
>> +	}
>> +}
> 
> You don't seem to be adding anything to this function in the series.
> Why add the stub?
> 
Right. Still not in use. I will remove and add per demand.
Thanks for your comments.