From: Randy Dunlap <rdunlap@infradead.org>
To: Michael Schmitz <schmitzmic@gmail.com>,
linux-m68k@vger.kernel.org, geert@linux-m68k.org
Cc: alex@kazik.de, netdev@vger.kernel.org
Subject: Re: [PATCH net v9 3/3] net/8390: apne.c - add 100 Mbit support to apne.c driver
Date: Mon, 8 Nov 2021 20:09:51 -0800 [thread overview]
Message-ID: <3d4c9e98-f004-755c-2f30-45b951ede6a6@infradead.org> (raw)
In-Reply-To: <20211109040242.11615-4-schmitzmic@gmail.com>
On 11/8/21 8:02 PM, Michael Schmitz wrote:
> diff --git a/drivers/net/ethernet/8390/Kconfig b/drivers/net/ethernet/8390/Kconfig
> index a4130e643342..b22c3cf96560 100644
> --- a/drivers/net/ethernet/8390/Kconfig
> +++ b/drivers/net/ethernet/8390/Kconfig
> @@ -136,6 +136,8 @@ config NE2K_PCI
> config APNE
> tristate "PCMCIA NE2000 support"
> depends on AMIGA_PCMCIA
> + select PCCARD
> + select PCMCIA
> select CRC32
Hi,
There are no other drivers that "select PCCARD" or
"select PCMCIA" in the entire kernel tree.
I don't see any good justification to allow it here.
--
~Randy
next prev parent reply other threads:[~2021-11-09 4:10 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-09 4:02 [PATCH v9 0/3] Add APNE PCMCIA 100 Mbit support Michael Schmitz
2021-11-09 4:02 ` [PATCH net v9 3/3] net/8390: apne.c - add 100 Mbit support to apne.c driver Michael Schmitz
2021-11-09 4:09 ` Randy Dunlap [this message]
2021-11-09 4:55 ` Michael Schmitz
2021-11-09 5:44 ` Randy Dunlap
2021-11-09 19:19 ` Michael Schmitz
2021-11-09 19:25 ` Randy Dunlap
2021-11-09 19:39 ` Michael Schmitz
2021-11-10 8:27 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3d4c9e98-f004-755c-2f30-45b951ede6a6@infradead.org \
--to=rdunlap@infradead.org \
--cc=alex@kazik.de \
--cc=geert@linux-m68k.org \
--cc=linux-m68k@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=schmitzmic@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).