From: Paolo Abeni <pabeni@redhat.com>
To: Tinsae Tadesse <tinsaetadesse2015@gmail.com>,
richardcochran@gmail.com, andrew+netdev@lunn.ch,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Fix PTP driver warnings by removing settime64 check
Date: Tue, 30 Dec 2025 10:42:47 +0100 [thread overview]
Message-ID: <3d6fbc23-e9b8-443c-badb-b3380b62d21f@redhat.com> (raw)
In-Reply-To: <20251229173346.8899-1-tinsaetadesse2015@gmail.com>
On 12/29/25 6:32 PM, Tinsae Tadesse wrote:
> Signed-off-by: Tinsae Tadesse <tinsaetadesse2015@gmail.com>
> ---
> drivers/ptp/ptp_clock.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/ptp/ptp_clock.c b/drivers/ptp/ptp_clock.c
> index b0e167c0b3eb..5374b3e9ad15 100644
> --- a/drivers/ptp/ptp_clock.c
> +++ b/drivers/ptp/ptp_clock.c
> @@ -323,8 +323,7 @@ struct ptp_clock *ptp_clock_register(struct ptp_clock_info *info,
> size_t size;
>
> if (WARN_ON_ONCE(info->n_alarm > PTP_MAX_ALARMS ||
> - (!info->gettimex64 && !info->gettime64) ||
> - !info->settime64))
> + (!info->gettimex64 && !info->gettime64)))
> return ERR_PTR(-EINVAL);
>
> /* Initialize a clock structure. */
I guess this is an attempt to address the following issue:
https://lore.kernel.org/all/20251108044822.GA3262936@ax162/
If so, it's already fixed by commit 81d90d93d22ca4f61833cba921dce9a0bd82218f
/P
next prev parent reply other threads:[~2025-12-30 9:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-29 17:32 [PATCH] Fix PTP driver warnings by removing settime64 check Tinsae Tadesse
2025-12-29 19:13 ` Vadim Fedorenko
[not found] ` <CAJ12PfM3zkJCJLJ3dLtvab2t9O9Dqs8MnoEo=zDb5OcyAPDuJQ@mail.gmail.com>
2025-12-30 10:59 ` Andrew Lunn
2025-12-30 11:50 ` TINSAE TADESSE GUTEMA
2025-12-30 9:42 ` Paolo Abeni [this message]
2025-12-30 10:08 ` TINSAE TADESSE GUTEMA
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3d6fbc23-e9b8-443c-badb-b3380b62d21f@redhat.com \
--to=pabeni@redhat.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=richardcochran@gmail.com \
--cc=tinsaetadesse2015@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).