From mboxrd@z Thu Jan 1 00:00:00 1970 From: Oleksandr Natalenko Subject: Re: CAKE and r8169 cause panic on upload in v4.19 Date: Sun, 28 Oct 2018 13:22:09 +0100 Message-ID: <3d749bf1ec48ee9f4172b23bde84ec4b@natalenko.name> References: <20181027.214426.537959459795607171.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Cc: dave.taht@gmail.com, hkallweit1@gmail.com, toke@toke.dk, jhs@mojatatu.com, xiyou.wangcong@gmail.com, jiri@resnulli.us, netdev@vger.kernel.org, linux-kernel@vger.kernel.org To: David Miller Return-path: Received: from vulcan.natalenko.name ([104.207.131.136]:23338 "EHLO vulcan.natalenko.name" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726406AbeJ1VGm (ORCPT ); Sun, 28 Oct 2018 17:06:42 -0400 In-Reply-To: <20181027.214426.537959459795607171.davem@davemloft.net> Sender: netdev-owner@vger.kernel.org List-ID: Hi. On 28.10.2018 05:44, David Miller wrote: > Does this fix it? > > diff --git a/net/core/dev.c b/net/core/dev.c > index 022ad73d6253..77d43ae2a7bb 100644 > --- a/net/core/dev.c > +++ b/net/core/dev.c > @@ -5457,7 +5457,7 @@ static void gro_flush_oldest(struct list_head > *head) > /* Do not adjust napi->gro_hash[].count, caller is adding a new > * SKB to the chain. > */ > - list_del(&oldest->list); > + skb_list_del_init(oldest); > napi_gro_complete(oldest); > } Yes, but I had to apply both a8305bff6852 and 992cba7e276d too to get it compiled. With these 3 patches the panic is not triggered any more while having GRO enabled. Thanks! -- Oleksandr Natalenko (post-factum)