From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4D7D4C43381 for ; Mon, 25 Mar 2019 08:51:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 198D920863 for ; Mon, 25 Mar 2019 08:51:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="lgTG73ed" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730003AbfCYIvm (ORCPT ); Mon, 25 Mar 2019 04:51:42 -0400 Received: from mail-wm1-f68.google.com ([209.85.128.68]:36554 "EHLO mail-wm1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726234AbfCYIvm (ORCPT ); Mon, 25 Mar 2019 04:51:42 -0400 Received: by mail-wm1-f68.google.com with SMTP id h18so8080072wml.1 for ; Mon, 25 Mar 2019 01:51:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=i77G9NBaJWQ+7cIaLeDeF65R8K5nkd292j6PpNo2lqE=; b=lgTG73edzExjJvcr8+TezobfGJ3wBjBbOSuOf1eieE+dm8q+KrZuHArrE19z93zqHp XEYwmKc2DkB1IvrLS40sJbotKSe4OJT6cYnN1eCCA3FjCoAMXM2IJYEYwcYzCsqlCbQu am0sVzUYouqwdTKMy7y5HzzFIsOoFuaqTTi/B1H56H23WBrupu1xKgh7e7oBZbXKvbiY aM69z8DnKHfyOy8S8PU3CO46HiBkHQMpzpsATAuczfG4KgJcijpXYOre1Z1XE5GLXsoE 6IFdYf5WUZlUTCy0zOS0sjqVGolZ7ae+kcFn/xNGCPH/KFv79GqqmXYoHySVtaqhcx4I Faaw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=i77G9NBaJWQ+7cIaLeDeF65R8K5nkd292j6PpNo2lqE=; b=NZg63eJOMx1KfNm79JS4zGCywSfLNUFMsROAxFEe3Lir2TI5r3ngCW98f+h2ImUlpm QNNyFlEQ0qGxDqSsWm7MAepSyZlgWcaSWmtY3y/ssRKvsRgXOmGoh6yjJkk59u80+9fS OOKtG/qAJoT2Z4+qelnJr/MJUUHl1DmQYAD+By8gwKNpHcjmrKSVHH2NBxrxJJzfNUgn eo8VXEY5TOxXVcWOOFLSOilUjgoDGEB+bPwPsvsXetdwScrUxDdeZyzDzprr1tKpEOAP 84/U9Hf0vhMhLSw6zUIPB+S17xneZE8/dyyg9E8anirKuRyMfUhRD94w2A4lQkOPb50/ mlOg== X-Gm-Message-State: APjAAAWUnlQMKSqV3b6AI7fcMNxcY8hYMc/dCD4HBt6Fv0mRnQEj7K+p OfW7oelbqY/h4mj1aLIOEjG1U/id X-Google-Smtp-Source: APXvYqxMqr/l6xKrig6LD2k6Edgud353UDKPj8VV3fI7Wr561rPr199K8ZgMBfYH4kW45DoHwExk0A== X-Received: by 2002:a1c:700a:: with SMTP id l10mr5072991wmc.13.1553503900962; Mon, 25 Mar 2019 01:51:40 -0700 (PDT) Received: from [192.168.8.147] (126.82.136.77.rev.sfr.net. [77.136.82.126]) by smtp.gmail.com with ESMTPSA id a14sm14840273wrx.96.2019.03.25.01.51.40 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 25 Mar 2019 01:51:40 -0700 (PDT) Subject: Re: [PATCH v2] net: use bulk free in kfree_skb_list To: Felix Fietkau , netdev@vger.kernel.org Cc: davem@davemloft.net, brouer@redhat.com, fw@strlen.de References: <20190324165644.21303-1-nbd@nbd.name> From: Eric Dumazet Message-ID: <3d7fd814-9525-f0a6-95ff-cccc2de8ecd8@gmail.com> Date: Mon, 25 Mar 2019 01:51:39 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20190324165644.21303-1-nbd@nbd.name> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 03/24/2019 09:56 AM, Felix Fietkau wrote: > Since we're freeing multiple skbs, we might as well use bulk free to save a > few cycles. Use the same conditions for bulk free as in napi_consume_skb. > I do not believe kfree_skb_list() is used in the fast path, so do we really need to make it so complex ?