From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C897BC433E0 for ; Fri, 22 Jan 2021 12:38:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7CD6C23437 for ; Fri, 22 Jan 2021 12:38:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727840AbhAVMhq (ORCPT ); Fri, 22 Jan 2021 07:37:46 -0500 Received: from mx3.molgen.mpg.de ([141.14.17.11]:45083 "EHLO mx1.molgen.mpg.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727401AbhAVMhi (ORCPT ); Fri, 22 Jan 2021 07:37:38 -0500 Received: from [192.168.0.6] (ip5f5aed2b.dynamic.kabel-deutschland.de [95.90.237.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: pmenzel) by mx.molgen.mpg.de (Postfix) with ESMTPSA id DACBA20647925; Fri, 22 Jan 2021 13:36:50 +0100 (CET) Subject: Re: [Intel-wired-lan] [PATCH net] ixgbe: add NULL pointer check before calling xdp_rxq_info_reg To: Yunjian Wang Cc: netdev@vger.kernel.org, intel-wired-lan@lists.osuosl.org, jerry.lilijun@huawei.com, xudingke@huawei.com, Jakub Kicinski , "David S. Miller" References: <1611314635-25592-1-git-send-email-wangyunjian@huawei.com> From: Paul Menzel Message-ID: <3d93455e-cfe5-4f03-0b25-bc1c61fb693d@molgen.mpg.de> Date: Fri, 22 Jan 2021 13:36:50 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.1 MIME-Version: 1.0 In-Reply-To: <1611314635-25592-1-git-send-email-wangyunjian@huawei.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Dear Yunjian, Thank you for looking at these issue. Am 22.01.21 um 12:23 schrieb wangyunjian: > From: Yunjian Wang > > The rx_ring->q_vector could be NULL, so it need to be checked before > calling xdp_rxq_info_reg. A small nit: need*s* > Fixes: b02e5a0ebb172 ("xsk: Propagate napi_id to XDP socket Rx path") > Addresses-Coverity: ("Dereference after null check") > Signed-off-by: Yunjian Wang > --- > drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c > index 6cbbe09ce8a0..7b76b3f448f7 100644 > --- a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c > +++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c > @@ -6586,8 +6586,9 @@ int ixgbe_setup_rx_resources(struct ixgbe_adapter *adapter, > rx_ring->next_to_use = 0; > > /* XDP RX-queue info */ > - if (xdp_rxq_info_reg(&rx_ring->xdp_rxq, adapter->netdev, > - rx_ring->queue_index, rx_ring->q_vector->napi.napi_id) < 0) > + if (rx_ring->q_vector && xdp_rxq_info_reg(&rx_ring->xdp_rxq, adapter->netdev, > + rx_ring->queue_index, > + rx_ring->q_vector->napi.napi_id) < 0) Unrelated, but I always wonder, if there shouldn’t be more logging for the error cases. > goto err; > > rx_ring->xdp_prog = adapter->xdp_prog; Reviewed-by: Paul Menzel Kind regards, Paul