From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpout-03.galae.net (smtpout-03.galae.net [185.246.85.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E38ED2FDC41 for ; Mon, 13 Oct 2025 09:37:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.246.85.4 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760348224; cv=none; b=Gp/3cIeXisk7++Bi/cBFRUvIRsXLNboIaarfyJn35yWdMHwpvdOq3KBxIjUZ4N2Ikj+iPiUyWQYB2eWTwftUjIEfyab8j0q5jmcGwtx5fyGjowV8yNFkKdgoti0TZQ9qyFF6wGWhw+PNd8SS+6zNvuS/ZEsv/WVSu/6vF38JW2Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760348224; c=relaxed/simple; bh=6LWJAszpBzDDNcwsP7mxSu6hCo8vBo3umaJU9IG9AP0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=K0F5Xezk+aIoUQwd7TxtTuHog5teeWjEYlWmFRrvM1bsvtf66/ARgbuHtWHDljZNRjbrpwSbYJ2GWonYaOUq2GgSCmoK0rXmFEanpmd7NHn/4Ozqu0Abqznuu0C31Y/URLcURS+WlimZ7LVSmkreeFCfRf9nx7AEsOvVagJBJRQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=dF2aK5md; arc=none smtp.client-ip=185.246.85.4 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="dF2aK5md" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-03.galae.net (Postfix) with ESMTPS id 1D8C04E41064; Mon, 13 Oct 2025 09:36:54 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id E04CD606C6; Mon, 13 Oct 2025 09:36:53 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 636D8102F2259; Mon, 13 Oct 2025 11:36:34 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1760348213; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:content-language:in-reply-to:references; bh=GttWDttud3s8DcIDHj6W8PemmzlZdLiY0kQdEAtHOtU=; b=dF2aK5mdeEn7pAgB9mHN5tqumXkPEF/bibVs7yjA/xahD27fzrPbBgkVsf7REjxjkjTUrd VbItglTchQQ0L5v+yazSwvc5MO51yx7a96RbZvWJd9rVjHvQIh80SHv+NTYA/dbs4OaKbM CJiFZfuKM2movztZpQmCYIf2QAkQJyK3+0gOwaTRa2pKAKD7dCMvWIg9p1m+ysA0gnGMrg qwid3vV/GeFENuifz2eH2lT083FS1pDFCwSWuE5rpQgLTNUZiknxNXb69AqLuOEpfz7Gzl xQJFCK+FebdOYbsW3i/bUyBi5nOW6wu9iK7LTBXSADzUH617Ht04XkwFJq7MiA== Message-ID: <3da0cdaf-d337-4c67-acdd-2f07e686e4f6@bootlin.com> Date: Mon, 13 Oct 2025 11:36:32 +0200 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [net,PATCH] net: phy: realtek: Avoid PHYCR2 access if PHYCR2 not present To: Marek Vasut , netdev@vger.kernel.org Cc: "David S. Miller" , Andrew Lunn , Daniel Golle , Eric Dumazet , Heiner Kallweit , Jakub Kicinski , Markus Stockhausen , Michael Klein , Paolo Abeni , Russell King References: <20251011110309.12664-1-marek.vasut@mailbox.org> From: Maxime Chevallier Content-Language: en-US In-Reply-To: <20251011110309.12664-1-marek.vasut@mailbox.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Last-TLS-Session-Version: TLSv1.3 Hi Marek, On 11/10/2025 13:02, Marek Vasut wrote: > The driver is currently checking for PHYCR2 register presence in > rtl8211f_config_init(), but it does so after accessing PHYCR2 to > disable EEE. This was introduced in commit bfc17c165835 ("net: > phy: realtek: disable PHY-mode EEE"). Move the PHYCR2 presence > test before the EEE disablement and simplify the code. > > Fixes: bfc17c165835 ("net: phy: realtek: disable PHY-mode EEE") > Signed-off-by: Marek Vasut Reviewed-by: Maxime Chevallier Thanks, Maxime