From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jamal Hadi Salim Subject: Re: [patch net-next v7 09/13] net: sched: allow ingress and clsact qdiscs to share filter blocks Date: Thu, 11 Jan 2018 09:37:08 -0500 Message-ID: <3da16333-3954-91c4-98c3-22a19d2bd5d9@mojatatu.com> References: <20180109140731.1022-1-jiri@resnulli.us> <20180109140731.1022-10-jiri@resnulli.us> <66883304-2004-7154-4700-9839203cecff@mojatatu.com> <20180111142457.GJ2053@nanopsycho.orion> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, davem@davemloft.net, xiyou.wangcong@gmail.com, mlxsw@mellanox.com, andrew@lunn.ch, vivien.didelot@savoirfairelinux.com, f.fainelli@gmail.com, michael.chan@broadcom.com, ganeshgr@chelsio.com, saeedm@mellanox.com, matanb@mellanox.com, leonro@mellanox.com, idosch@mellanox.com, jakub.kicinski@netronome.com, simon.horman@netronome.com, pieter.jansenvanvuuren@netronome.com, john.hurley@netronome.com, alexander.h.duyck@intel.com, ogerlitz@mellanox.com, john.fastabend@gmail.com, daniel@iogearbox.net, dsahern@gmail.com To: Jiri Pirko Return-path: Received: from mail-it0-f66.google.com ([209.85.214.66]:40500 "EHLO mail-it0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932215AbeAKOhM (ORCPT ); Thu, 11 Jan 2018 09:37:12 -0500 Received: by mail-it0-f66.google.com with SMTP id f190so4743560ita.5 for ; Thu, 11 Jan 2018 06:37:11 -0800 (PST) In-Reply-To: <20180111142457.GJ2053@nanopsycho.orion> Content-Language: en-GB Sender: netdev-owner@vger.kernel.org List-ID: On 18-01-11 09:24 AM, Jiri Pirko wrote: > Thu, Jan 11, 2018 at 02:36:01PM CET, jhs@mojatatu.com wrote: >> On 18-01-09 09:07 AM, Jiri Pirko wrote: >>> From: Jiri Pirko >>> >>> Benefit from the previously introduced shared filter blocks >>> infrastructure and allow ingress and clsact qdisc instances to share >>> filter blocks. The block index is coming from userspace as qdisc option. >> >> Didnt quiet follow why ingress is special and needs attributes to >> set the block but other qdiscs didnt. > > Jamal, again, other qdiscs does not support block sharing. This patchset > only adds support for sharing of block for ingress and clsact qdiscs. > Later on, other qdiscs could also support block sharing. > Can you stop a config which says: tc qdisc add dev ens9 root block 22 handle 1:0 prio ? cheers, jamal