From mboxrd@z Thu Jan  1 00:00:00 1970
From: Florian Fainelli <f.fainelli@gmail.com>
Subject: Re: [PATH RFC net-next 2/8] net: phy: Add phydev_warn()
Date: Fri, 14 Sep 2018 15:10:36 -0700
Message-ID: <3da34be9-2960-9867-a421-976df5e09f7c@gmail.com>
References: <1536961136-30453-1-git-send-email-andrew@lunn.ch>
 <1536961136-30453-3-git-send-email-andrew@lunn.ch>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
To: Andrew Lunn <andrew@lunn.ch>, netdev <netdev@vger.kernel.org>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-wm1-f68.google.com ([209.85.128.68]:34982 "EHLO
        mail-wm1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1726942AbeIOD1F (ORCPT
        <rfc822;netdev@vger.kernel.org>); Fri, 14 Sep 2018 23:27:05 -0400
Received: by mail-wm1-f68.google.com with SMTP id o18-v6so3442057wmc.0
        for <netdev@vger.kernel.org>; Fri, 14 Sep 2018 15:10:40 -0700 (PDT)
In-Reply-To: <1536961136-30453-3-git-send-email-andrew@lunn.ch>
Content-Language: en-US
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On 09/14/2018 02:38 PM, Andrew Lunn wrote:
> Not all new style LINK_MODE bits can be converted into old style
> SUPPORTED bits. We need to warn when such a conversion is attempted.
> Add a helper for this.
> 
> Signed-off-by: Andrew Lunn <andrew@lunn.ch>

Acked-by: Florian Fainelli <f.fainelli@gmail.com>

Do you mind converting drivers/net/phy/marvell10g.c to use it? I would
also suggest adding phydev_info() while we are at it and do the two
conversions to it that exist in drivers/net/phy/phy_device.c?

Thanks!
-- 
Florian