From: David Ahern <dsahern@gmail.com>
To: Ido Schimmel <idosch@idosch.org>
Cc: netdev@vger.kernel.org, jiri@mellanox.com, idosch@mellanox.com,
johannes.berg@intel.com
Subject: Re: [PATCH net-next 3/3] mlxsw: spectrum_router: Return extack message on abort due to fib rules
Date: Thu, 26 Oct 2017 09:30:50 -0600 [thread overview]
Message-ID: <3dcd4a80-d94f-19a2-3238-49d329af1b60@gmail.com> (raw)
In-Reply-To: <20171026063846.GA19803@shredder.mtl.com>
On 10/26/17 12:38 AM, Ido Schimmel wrote:
>
> Nice idea, but one problem is that the FIB notifier is atomic and thus
> when you trigger abort you end up sleeping in an atomic context:
>
...
>
> How about we keep the checking and error reporting inline, but do the
> actual abort in a workqueue?
yep. Will spin a v2.
prev parent reply other threads:[~2017-10-26 15:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-26 5:08 [PATCH net-next 0/3] net: Allow non-fatal messages to be passed in extack David Ahern
2017-10-26 5:08 ` [PATCH net-next 1/3] netlink: Allow ext_ack to carry non-error messages David Ahern
2017-10-26 5:08 ` [PATCH net-next 2/3] net: Add extack to fib_notifier_info David Ahern
2017-10-26 5:08 ` [PATCH net-next 3/3] mlxsw: spectrum_router: Return extack message on abort due to fib rules David Ahern
2017-10-26 6:26 ` Jiri Pirko
2017-10-26 6:40 ` Ido Schimmel
2017-10-26 6:38 ` Ido Schimmel
2017-10-26 15:30 ` David Ahern [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3dcd4a80-d94f-19a2-3238-49d329af1b60@gmail.com \
--to=dsahern@gmail.com \
--cc=idosch@idosch.org \
--cc=idosch@mellanox.com \
--cc=jiri@mellanox.com \
--cc=johannes.berg@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).