From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from fhigh-a2-smtp.messagingengine.com (fhigh-a2-smtp.messagingengine.com [103.168.172.153]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 94C51156F20; Sat, 21 Feb 2026 14:25:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=103.168.172.153 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771683935; cv=none; b=dVWawapUHDWFb0vV+S6gdePCjo2nykBh5ez8KbRWVKqectEcMkgL4Ig/nOhq8YOQWxAhrDddvoHSKasHhwfWz10HJ5DE5OCft/mtRtQ52jK8W+4BphyWyBEOzvoSp9Ljxm3YJ8aB9Wcvbhtke9P9xLq+GsdDMVdzwzDKqOrlZ+w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771683935; c=relaxed/simple; bh=otMyq/aQ3qug49eFV1PgpQjmdBBXQNS8WTZj5UYz3/8=; h=MIME-Version:Date:From:To:Cc:Message-Id:In-Reply-To:References: Subject:Content-Type; b=gxw7wZCVPrccLD9S5fR1BPnMmXq18YEaq99IpAK8oZmss0l25wfUMiL/Kt3fK5PsdyzWA5uOH3cPVc5ojT5XiItQqPeMjEzhgBcdCLO1xrOK8gXEAjpvIKyP4loNHEWGOhH/gDpWnjfFmlxCCVjSDOTbosbmqJCjyuxMJDr6hBY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arndb.de; spf=pass smtp.mailfrom=arndb.de; dkim=pass (2048-bit key) header.d=arndb.de header.i=@arndb.de header.b=Cc7wubvG; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b=TXwF0A3f; arc=none smtp.client-ip=103.168.172.153 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arndb.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arndb.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=arndb.de header.i=@arndb.de header.b="Cc7wubvG"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="TXwF0A3f" Received: from phl-compute-04.internal (phl-compute-04.internal [10.202.2.44]) by mailfhigh.phl.internal (Postfix) with ESMTP id 8D9B114000AF; Sat, 21 Feb 2026 09:25:32 -0500 (EST) Received: from phl-imap-02 ([10.202.2.81]) by phl-compute-04.internal (MEProxy); Sat, 21 Feb 2026 09:25:32 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arndb.de; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm3; t=1771683932; x=1771770332; bh=GFuuMBED/UJaIkcfl/purSOfaX3aDg7So0nftdQcupg=; b= Cc7wubvGSlVCzIGR4PFcGRLjg2jbz0QNqUNGQCkKC8WxAK3FH0mRmvgWizTkEAdz Zp6wvxCnfFVGHnTpEpm1YwNt3polZYWMky4g8jMaCmXTkOPslCwxY33A17nCzrb2 16zyofTpKb2jbJx2Bi5Ir65B9LDPzHM7+uX8xDvBoUWayfZDrJIpd6eFsiuDDxua zHosKu9mHbtuxGBmdZPXhIX+PsbnZGZjMyx1rNgfrRykNBz4nLAw+kjmQa326Sar 5rE9HzpwU2G28EADonHnlqQl38wYau3P4atRGoddTTiH3HavaHmwOHy7I7A3Wf+f +JYCmCzl4pJSvOBYmpojsA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1771683932; x= 1771770332; bh=GFuuMBED/UJaIkcfl/purSOfaX3aDg7So0nftdQcupg=; b=T XwF0A3fSWkILfVh8WoG70+zGpGTm0kSKrMh2KOla/rb07ZRFLoK335pvqL9d/IPY 9YHh8visIVsQHr6y4IXVgduOyyMONeYNKQ+sZrcyscNGN9McMmUIEXZQO//uFMGw DoZRvfO+kLkNpbig+KElLU6+ZtvmUsfvOeCxbeY+HbPq5vO9MNUcIWv07NPuXoEH yP/HRJyKeHcaU4fKvWDjAsiszodjbfZEF7SBCGQuZgXKZ9uL89Z/JjzDyz8Bcdy7 v3hdabEqMTXPCIY1yfWQhcTDfquZtotTKpb52FLnnx1/932brIzdrUx6dlyqJRy4 9edPA1/uUxFf77ZzB8yow== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefgedrtddtgddvfeduiedtucetufdoteggodetrf dotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfurfetoffkrfgpnffqhgenuceu rghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujf gurhepofggfffhvfevkfgjfhfutgfgsehtjeertdertddtnecuhfhrohhmpedftehrnhgu uceuvghrghhmrghnnhdfuceorghrnhgusegrrhhnuggsrdguvgeqnecuggftrfgrthhtvg hrnhephfdthfdvtdefhedukeetgefggffhjeeggeetfefggfevudegudevledvkefhvdei necuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomheprghrnh gusegrrhhnuggsrdguvgdpnhgspghrtghpthhtohepuddvpdhmohguvgepshhmthhpohhu thdprhgtphhtthhopegurghvvghmsegurghvvghmlhhofhhtrdhnvghtpdhrtghpthhtoh epohhlthgvrghnvhesghhmrghilhdrtghomhdprhgtphhtthhopegvughumhgriigvthes ghhoohhglhgvrdgtohhmpdhrtghpthhtoheprghrnhgusehkvghrnhgvlhdrohhrghdprh gtphhtthhopehkuhgsrgeskhgvrhhnvghlrdhorhhgpdhrtghpthhtoheprghnughrvgif sehluhhnnhdrtghhpdhrtghpthhtohepuggrnhhivghlsehmrghkrhhothhophhirgdroh hrghdprhgtphhtthhopehprggsvghnihesrhgvughhrghtrdgtohhmpdhrtghpthhtohep lhhinhhugiesrhhovggtkhdquhhsrdhnvght X-ME-Proxy: Feedback-ID: i56a14606:Fastmail Received: by mailuser.phl.internal (Postfix, from userid 501) id DA248700065; Sat, 21 Feb 2026 09:25:31 -0500 (EST) X-Mailer: MessagingEngine.com Webmail Interface Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-ThreadId: ABuPgj6G8jlB Date: Sat, 21 Feb 2026 15:24:44 +0100 From: "Arnd Bergmann" To: "Guenter Roeck" , "Daniel Golle" Cc: "Arnd Bergmann" , "Andrew Lunn" , "Vladimir Oltean" , "David S . Miller" , "Eric Dumazet" , "Jakub Kicinski" , "Paolo Abeni" , Netdev , linux-kernel@vger.kernel.org, linux-hwmon@vger.kernel.org Message-Id: <3deb6138-e331-4e35-bc56-653a0a741a46@app.fastmail.com> In-Reply-To: <9d7aee5a-ac46-47d9-ac26-0f3a63b6a8ab@roeck-us.net> References: <20260216105522.2382373-1-arnd@kernel.org> <306e79fb-f3ee-434e-a90e-547e97d2a5aa@roeck-us.net> <70a195ab-3b61-47fb-a361-17b53cf7bdda@roeck-us.net> <316a6ee6-9e5e-4518-8dc4-2f39805934a9@app.fastmail.com> <9d7aee5a-ac46-47d9-ac26-0f3a63b6a8ab@roeck-us.net> Subject: Re: [PATCH] net: dsa: MxL862xx: don't force-enable MAXLINEAR_GPHY Content-Type: text/plain Content-Transfer-Encoding: 7bit On Sat, Feb 21, 2026, at 02:25, Guenter Roeck wrote: > On 2/16/26 08:27, Arnd Bergmann wrote: >> On Mon, Feb 16, 2026, at 17:22, Daniel Golle wrote: >>> On Mon, Feb 16, 2026 at 08:20:41AM -0800, Guenter Roeck wrote: >> >> What I meant above is that I had considered and rejected the extra >> dependencies in the ethernet driver. I don't think there is a good >> way to add inline helpers. Technically, one could use IS_REACHABLE() >> here, to stub out the functions when the caller is built-in, but >> I find that even worse because it replaces a trivial build-time >> failure with very subtle runtime bug. >> > > Lots of kernel APIs have dummy implementations. hwmon isn't really that > different to those. Also, arguably, that would not be a subtle runtime > bug but a feature. I would argue that all of them are wrong. I currently count 33 uses of IS_REACHABLE() in header files, which is not a lot, but I would prefer replacing these with proper Kconfig dependencies than to add more for cases we already handle correctly. Arnd