From: "lipeng (Y)" <lipeng321@huawei.com>
To: David Miller <davem@davemloft.net>
Cc: <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linuxarm@huawei.com>, <salil.mehta@huawei.com>
Subject: Re: [PATCH V2 net-next 01/17] net: hns3: add support to query tqps number
Date: Wed, 20 Dec 2017 14:14:58 +0800 [thread overview]
Message-ID: <3df115cc-1b66-b05a-d222-eb4f1d24879d@huawei.com> (raw)
In-Reply-To: <20171219.141644.1574828912135603880.davem@davemloft.net>
On 2017/12/20 3:16, David Miller wrote:
> From: Lipeng <lipeng321@huawei.com>
> Date: Tue, 19 Dec 2017 12:02:23 +0800
>
>> @@ -5002,6 +5002,26 @@ static void hclge_uninit_ae_dev(struct hnae3_ae_dev *ae_dev)
>> ae_dev->priv = NULL;
>> }
>>
>> +static u32 hclge_get_max_channels(struct hnae3_handle *handle)
>> +{
>> + struct hclge_vport *vport = hclge_get_vport(handle);
>> + struct hnae3_knic_private_info *kinfo = &handle->kinfo;
>> + struct hclge_dev *hdev = vport->back;
>> +
> Please order local variables from longest to shortest line.
>
> Please audit your entire submission for this problem.
>
> .
will check this patch-set about this problem. Thanks
next prev parent reply other threads:[~2017-12-20 6:14 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-19 4:02 [PATCH V2 net-next 00/17] add some features and fix some bugs for HNS3 driver Lipeng
2017-12-19 4:02 ` [PATCH V2 net-next 01/17] net: hns3: add support to query tqps number Lipeng
2017-12-19 19:16 ` David Miller
2017-12-20 6:14 ` lipeng (Y) [this message]
2017-12-19 4:02 ` [PATCH V2 net-next 02/17] net: hns3: add support to modify " Lipeng
2017-12-19 19:18 ` David Miller
2017-12-20 6:15 ` lipeng (Y)
2017-12-19 4:02 ` [PATCH V2 net-next 03/17] net: hns3: change the returned tqp number by ethtool -x Lipeng
2017-12-19 4:02 ` [PATCH V2 net-next 04/17] net: hns3: Free the ring_data structrue when change tqps Lipeng
2017-12-19 4:02 ` [PATCH V2 net-next 05/17] net: hns3: Get rss_size_max from configuration but not hardcode Lipeng
2017-12-19 4:02 ` [PATCH V2 net-next 06/17] net: hns3: Add a mask initialization for mac_vlan table Lipeng
2017-12-19 4:02 ` [PATCH V2 net-next 07/17] net: hns3: Add vlan offload config command Lipeng
2017-12-19 4:02 ` [PATCH V2 net-next 08/17] net: hns3: Add ethtool related offload command Lipeng
2017-12-19 4:02 ` [PATCH V2 net-next 09/17] net: hns3: Add handling vlan tag offload in bd Lipeng
2017-12-19 4:02 ` [PATCH V2 net-next 10/17] net: hns3: cleanup mac auto-negotiation state query Lipeng
2017-12-19 4:02 ` [PATCH V2 net-next 11/17] net: hns3: fix for getting auto-negotiation state in hclge_get_autoneg Lipeng
2017-12-19 4:02 ` [PATCH V2 net-next 12/17] net: hns3: add support for set_pauseparam Lipeng
2017-12-19 4:02 ` [PATCH V2 net-next 13/17] net: hns3: add support to update flow control settings after autoneg Lipeng
2017-12-19 4:02 ` [PATCH V2 net-next 14/17] net: hns3: add Asym Pause support to phy default features Lipeng
2017-12-19 4:02 ` [PATCH V2 net-next 15/17] net: hns3: add support for querying advertised pause frame by ethtool ethx Lipeng
2017-12-19 4:02 ` [PATCH V2 net-next 16/17] net: hns3: Increase the default depth of bucket for TM shaper Lipeng
2017-12-19 4:02 ` [PATCH V2 net-next 17/17] net: hns3: change TM sched mode to TC-based mode when SRIOV enabled Lipeng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3df115cc-1b66-b05a-d222-eb4f1d24879d@huawei.com \
--to=lipeng321@huawei.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=salil.mehta@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox