From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oa1-f51.google.com (mail-oa1-f51.google.com [209.85.160.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A886E2797B7 for ; Tue, 1 Jul 2025 15:17:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751383032; cv=none; b=oTXwVbMuceWO9uvDIGBc4E8CD3SeUyNxsmqwgZOQNuJkaxfGLHsFI/G8LMmNAvNL7ZrlTBlaRZPKSXMeVR4yW3+YLP755a9OrC1Z4AOlViPEZmGAsR3SB2kekHGhfWKkFbkU2teVGXAfeKLt5pWi05OV8lMXoJXlv19vzPiqIuI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751383032; c=relaxed/simple; bh=UzPkDkcjv+i8GzG9JMJlLQc03B+nxyKMyUaYhYyrDlA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=YRWwR12OgeNeO7JCC2Pgzqeiy2P1IqWohsz2IkvHGYtMss+2dcPqzZrvp04p+OZ2AXLI3gj1ut8y2w3yJuIKlBIwdOK9I9+w6BZe2qolOYKaNEeOI3CxxC2fOCUsWShQrBz3ljtWGWxZBVOwT79uk8Ixhwkm4jlmohzbtmN/SQA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=rz3jzmyv; arc=none smtp.client-ip=209.85.160.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="rz3jzmyv" Received: by mail-oa1-f51.google.com with SMTP id 586e51a60fabf-2efc0ed41efso1755438fac.1 for ; Tue, 01 Jul 2025 08:17:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1751383028; x=1751987828; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=kto2WDWq8SXrCfQMl14bP+htdglCH2HfwzImspNOE2s=; b=rz3jzmyvMRtwfCYzWAj+nFIzBvzDNOCFbrt0YTJ7/pkdCVdJ8ZbeHkDT0nQgPNDTGf Wih9y1yq8MJkVSiEbVTwDGADtlljJR5FsO4DHb4DFJZNn1aEYtC42MxXUc17eF8ppr17 BlG0wEty7LAu1mBiYhHLBUK+u2WEhkwuNMVV05EnuvJIuGjhp1gSvKp0LG6FWfe1fTZl WhcrRPGPb61hwLzJMSpaSxB9YLXUJ755Zt4cVdfZHkyeX4pm8gRcavNlxWitr6s1zcsK ZIYHq/4EnGAj8sIiltlInirkE7HO65dPxkx2Ngj+bpUFtuWYTPhkga+5j70VDejI213d i+cQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751383028; x=1751987828; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=kto2WDWq8SXrCfQMl14bP+htdglCH2HfwzImspNOE2s=; b=Vh3tEIefjZN5im3lVnkt4OLh7G6CI3i2/br95QEtRHkefWqLOeUZl0fhRdvHyBHT+A XXM8y0K37yNh+ogc8bO032u7UiQ+9NnwwQMqqU0Zz6GZHX0bVQNHH6MaC+35UKjz+Hj1 v7SUODcCcuDYtVGMn5N1qPYifL6T8rj8BSprTFTtXThPRivD4S0GILJS6HbjlTpuc3x+ htb116ZP8VO7/i0JHBIwbbzhsGQGw2WS6PstEvMcKek67nj/Z4v/P1ZBNTzOqK8bipYa mAvmtk0qSa7ccFHgQyrznDYfbB+Dxv1hSeS+ClhLKDqJrrPUv8sCRb7atkR3RY+Ss9xo doMw== X-Forwarded-Encrypted: i=1; AJvYcCX4PvrPI8wLNPcBjutcfxnjDlWEkx8GAdKwM3a0KEM7uZF7511ko5a2QmbPQeOxkgA6g4iwm24=@vger.kernel.org X-Gm-Message-State: AOJu0YwaO8gJ3YfzqxK5i3ms+a6yVrmpVduHz59z5UGSnXGzD1qePFhT LGYxztq5UpQBfuRT7G9B6FoIG3y1sI2tPmPZ9NyoakSjlsJxSqkMeRhJ8aFx6SfGXfE= X-Gm-Gg: ASbGncukbz5M7tZfQTeIRP0C0T382UQPgIjqgP2qzws+Nv82qqsKN88tqXZzzFC+Jds eB7F9+SrFtygFQ6gNPqhl4JFZBVgvrGP564OvvFvBkKz+XRmnQSb4L2DvpRkYsWnR9CKaT/iiOQ F1LhPgE/VVV17j9ZmIoxybff/p0harRynVOoXH4VWKxrj6YdCecycrFNsCtyISfwKb7AbzojXHd r6uqzran8+ir6OH/Fi/uBcRTWjmhsd79RhsWVgOrl10NVJ7WaHKid7fHNvhu5+PcfFPuoRXh4AI C2I8bVCrPIdyARQrzjpTrzIZFu9b8amlnlICvm0ZhzXa2l4R1BDG4qpWCpyl7CtA1c3DnQjWF8X P/U8+Igfr8swzz78KmBDCd/uS3SZ2SygEvJQyxcI= X-Google-Smtp-Source: AGHT+IGFKFZEsYZ4erbtAtqvl8tEHdHdyZFtcG8OKzWXPDqsQnJB5BtiKcEBEjaczDbwqY+Qnse9tA== X-Received: by 2002:a05:6871:82a:b0:2c7:6f57:3645 with SMTP id 586e51a60fabf-2efed67879emr12142176fac.18.1751383010329; Tue, 01 Jul 2025 08:16:50 -0700 (PDT) Received: from ?IPV6:2600:8803:e7e4:1d00:70a7:ca49:a250:f1d5? ([2600:8803:e7e4:1d00:70a7:ca49:a250:f1d5]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-2efd50fb14esm3319606fac.42.2025.07.01.08.16.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 01 Jul 2025 08:16:49 -0700 (PDT) Message-ID: <3df2c424-297e-4538-b350-5c465b22fa39@baylibre.com> Date: Tue, 1 Jul 2025 10:16:47 -0500 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] Remove error prints for devm_add_action_or_reset() To: Waqar Hameed , Vignesh Raghavendra , Julien Panis , William Breathitt Gray , Linus Walleij , Bartosz Golaszewski , Peter Rosin , Jonathan Cameron , =?UTF-8?Q?Nuno_S=C3=A1?= , Andy Shevchenko , Cosmin Tanislav , Lars-Peter Clausen , Michael Hennerich , Matthias Brugger , AngeloGioacchino Del Regno , Matteo Martelli , Heiko Stuebner , Francesco Dolcini , =?UTF-8?Q?Jo=C3=A3o_Paulo_Gon=C3=A7alves?= , Hugo Villeneuve , Subhajit Ghosh , Mudit Sharma , Gerald Loacker , Song Qiang , Crt Mori , Dmitry Torokhov , Ulf Hansson , Karol Gugala , Mateusz Holenko , Gabriel Somlo , Joel Stanley , Claudiu Manoil , Vladimir Oltean , Wei Fang , Clark Wang , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Vinod Koul , Kishon Vijay Abraham I , Krzysztof Kozlowski , Alim Akhtar , Sebastian Reichel , =?UTF-8?Q?Uwe_Kleine-K=C3=B6nig?= , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Han Xu , Haibo Chen , Yogesh Gaur , Mark Brown , Avri Altman , Bart Van Assche , "James E.J. Bottomley" , "Martin K. Petersen" , Souradeep Chowdhury , Greg Kroah-Hartman , Liam Girdwood , Peter Ujfalusi , Bard Liao , Ranjani Sridharan , Daniel Baluta , Kai Vehmanen , Pierre-Louis Bossart , Jaroslav Kysela , Takashi Iwai , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam Cc: kernel@axis.com, linux-iio@vger.kernel.org, linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, linux-i2c@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-input@vger.kernel.org, linux-mmc@vger.kernel.org, imx@lists.linux.dev, netdev@vger.kernel.org, linux-phy@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-pm@vger.kernel.org, linux-pwm@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-spi@vger.kernel.org, linux-scsi@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-usb@vger.kernel.org, sound-open-firmware@alsa-project.org, linux-sound@vger.kernel.org References: Content-Language: en-US From: David Lechner In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 7/1/25 10:03 AM, Waqar Hameed wrote: > When `devm_add_action_or_reset()` fails, it is due to a failed memory > allocation and will thus return `-ENOMEM`. `dev_err_probe()` doesn't do > anything when error is `-ENOMEM`. Therefore, remove the useless call to > `dev_err_probe()` when `devm_add_action_or_reset()` fails, and just > return the value instead. > > Signed-off-by: Waqar Hameed > --- I can't speak for all subsystems, but this would probably be acceptable in the iio subsystem. However, I don't think anyone is going to accept a patch that touches all of these files at the same time across subsystems. So I would suggest to split this up into one patch per driver and create one series per subsystem. This way, each subsystem isn't bothered by unrelated patches that they don't particularly need to care about. And note that some subsystems like net have additional expectations, e.g for the patch subject so that it gets picked up by automated tools, so be sure to check the docs for this.