From: Eric Dumazet <eric.dumazet@gmail.com>
To: Nathan Chancellor <natechancellor@gmail.com>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] bpf/test_run: Add braces to initialization in bpf_prog_test_run_skb
Date: Fri, 19 Oct 2018 11:46:24 -0700 [thread overview]
Message-ID: <3e2e5343-3ead-5b4d-758d-14f04183b39e@gmail.com> (raw)
In-Reply-To: <20181019182649.24301-1-natechancellor@gmail.com>
On 10/19/2018 11:26 AM, Nathan Chancellor wrote:
> Clang warns:
>
> net/bpf/test_run.c:120:20: error: suggest braces around initialization
> of subobject [-Werror,-Wmissing-braces]
> struct sock sk = {0};
> ^
> {}
>
> Add the braces to properly initialize all subobjects.
>
> Fixes: 75079847e9d0 ("bpf: add tests for direct packet access from CGROUP_SKB")
> Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
> ---
> net/bpf/test_run.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/bpf/test_run.c b/net/bpf/test_run.c
> index 8dccac305268..65e049c61a7a 100644
> --- a/net/bpf/test_run.c
> +++ b/net/bpf/test_run.c
> @@ -117,7 +117,7 @@ int bpf_prog_test_run_skb(struct bpf_prog *prog, const union bpf_attr *kattr,
> u32 retval, duration;
> int hh_len = ETH_HLEN;
> struct sk_buff *skb;
> - struct sock sk = {0};
> + struct sock sk = { { {0} } };
> void *data;
> int ret;
>
>
Strange, I thought this patch was still under discussion.
Has an old version of it being merged somewhere ?
next prev parent reply other threads:[~2018-10-19 18:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-19 18:26 [PATCH] bpf/test_run: Add braces to initialization in bpf_prog_test_run_skb Nathan Chancellor
2018-10-19 18:46 ` Eric Dumazet [this message]
2018-10-19 18:47 ` Alexei Starovoitov
2018-10-19 19:03 ` Nathan Chancellor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3e2e5343-3ead-5b4d-758d-14f04183b39e@gmail.com \
--to=eric.dumazet@gmail.com \
--cc=ast@kernel.org \
--cc=daniel@iogearbox.net \
--cc=linux-kernel@vger.kernel.org \
--cc=natechancellor@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).