From: Jacob Keller <jacob.e.keller@intel.com>
To: Jiri Pirko <jiri@resnulli.us>, <netdev@vger.kernel.org>
Cc: <davem@davemloft.net>, <kuba@kernel.org>, <pabeni@redhat.com>,
<edumazet@google.com>, <tariqt@nvidia.com>, <saeedm@nvidia.com>,
<gal@nvidia.com>, <kim.phillips@amd.com>, <moshe@nvidia.com>,
<simon.horman@corigine.com>, <idosch@nvidia.com>
Subject: Re: [patch net-next v2 5/7] devlink: convert param list to xarray
Date: Fri, 10 Feb 2023 11:37:50 -0800 [thread overview]
Message-ID: <3e6ddb39-02dc-ec30-0085-0a9c70664c5e@intel.com> (raw)
In-Reply-To: <20230210100131.3088240-6-jiri@resnulli.us>
On 2/10/2023 2:01 AM, Jiri Pirko wrote:
> From: Jiri Pirko <jiri@nvidia.com>
>
> Loose the linked list for params and use xarray instead.
>
> Note that this is required to be eventually possible to call
> devl_param_driverinit_value_get() without holding instance lock.
>
> Signed-off-by: Jiri Pirko <jiri@nvidia.com>
> Reviewed-by: Simon Horman <simon.horman@corigine.com>
> Acked-by: Jakub Kicinski <kuba@kernel.org>
That makes loading by the parameter id faster too since we don't have to
iterate the full list. Nice.
Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
next prev parent reply other threads:[~2023-02-10 19:41 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-10 10:01 [patch net-next v2 0/7] devlink: params cleanups and devl_param_driverinit_value_get() fix Jiri Pirko
2023-02-10 10:01 ` [patch net-next v2 1/7] devlink: don't use strcpy() to copy param value Jiri Pirko
2023-02-10 19:33 ` Jacob Keller
2023-02-10 10:01 ` [patch net-next v2 2/7] devlink: make sure driver does not read updated driverinit param before reload Jiri Pirko
2023-02-10 10:33 ` Simon Horman
2023-02-10 10:01 ` [patch net-next v2 3/7] devlink: fix the name of value arg of devl_param_driverinit_value_get() Jiri Pirko
2023-02-10 19:35 ` Jacob Keller
2023-02-10 10:01 ` [patch net-next v2 4/7] devlink: use xa_for_each_start() helper in devlink_nl_cmd_port_get_dump_one() Jiri Pirko
2023-02-10 19:36 ` Jacob Keller
2023-02-10 10:01 ` [patch net-next v2 5/7] devlink: convert param list to xarray Jiri Pirko
2023-02-10 19:37 ` Jacob Keller [this message]
2023-02-10 10:01 ` [patch net-next v2 6/7] devlink: allow to call devl_param_driverinit_value_get() without holding instance lock Jiri Pirko
2023-02-10 19:41 ` Jacob Keller
2023-02-13 7:44 ` Jiri Pirko
2023-02-10 22:11 ` Kim Phillips
2023-02-10 10:01 ` [patch net-next v2 7/7] devlink: add forgotten devlink instance lock assertion to devl_param_driverinit_value_set() Jiri Pirko
2023-02-10 19:42 ` Jacob Keller
2023-02-13 10:00 ` [patch net-next v2 0/7] devlink: params cleanups and devl_param_driverinit_value_get() fix patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3e6ddb39-02dc-ec30-0085-0a9c70664c5e@intel.com \
--to=jacob.e.keller@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gal@nvidia.com \
--cc=idosch@nvidia.com \
--cc=jiri@resnulli.us \
--cc=kim.phillips@amd.com \
--cc=kuba@kernel.org \
--cc=moshe@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=saeedm@nvidia.com \
--cc=simon.horman@corigine.com \
--cc=tariqt@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).