From: Ursula Braun <ubraun@linux.vnet.ibm.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, linux-s390@vger.kernel.org,
schwidefsky@de.ibm.com, heiko.carstens@de.ibm.com,
stable@vger.kernel.org
Subject: Re: [PATCH net-next 13/13] s390/qeth: remove OSN-devices
Date: Fri, 13 Jan 2017 12:55:28 +0100 [thread overview]
Message-ID: <3e706715-0b5f-8011-3a2d-e1f66a37661f@linux.vnet.ibm.com> (raw)
In-Reply-To: <20170111.090502.567203023670760362.davem@davemloft.net>
On 01/11/2017 03:05 PM, David Miller wrote:
> From: Ursula Braun <ubraun@linux.vnet.ibm.com>
> Date: Wed, 11 Jan 2017 12:56:00 +0100
>
>> CHPID type "OSN" is a device type which had been used by IBM product
>> "Communication Controller for Linux". This product has reached end of
>> service in March 2016. Thus OSN support can be removed from the qeth
>> driver.
>>
>> Signed-off-by: Ursula Braun <ubraun@linux.vnet.ibm.com>
>> Reviewed-by: Julian Wiedmann <jwi@linux.vnet.ibm.com>
>> Reviewed-by: Thomas Richter <tmricht@linux.vnet.ibm.com>
>
> IBM can certainly decide what physical products it wants to support
> or not, but this doesn't directly apply to what the Linux kernel
> driver supports.
>
> We do not unilaterally remove support for a chip from a driver just
> because the vendor decides to stop supporting that chip. In fact this
> is one of the main benefits and value-adds of Linux.
>
> I'm not applying a patch series that removes support for a chipset
> for this reason, sorry.
>
Dave,
I am not sure, if the stopped chip support of vendors is something
equivalent to the removal of OSN-CHPID support for s390. Probably
I used misleading terms like "OSN-device" in my patch description:
The standard networking card on s390 is called
"Open Systems Adapter-Express card" (shortly "OSA-card"), and for sure
the qeth driver continues to support it in general. Besides covering
traditional Ethernet traffic, an OSA-card can also be used for very
IBM-specific purposes.
The mode an OSA-card is running is configured outside of Linux in
the mainframe hardware configuration. Linux supports a subset of
these modes with the qeth and lcs drivers.
One very specific OSA-mode is the OSN-mode. This mode is one building
block for a Linux-assisted approach that allows
existing IBM mainframe operating systems to continue to run
IBM Systems Network Architecture (SNA) protocol programs.
Just these SNA related code parts in qeth would be removed with
this patch.
Do you still think it is important to keep code just needed for
IBM SNA traffic in the kernel?
Token Ring support for instance has been removed in 2012. Isn't this
something comparable to my intended removal of OSN-mode support in qeth?
In other words: Would it make sense to resend my patch with a better
description?
Kind regards, Ursula
prev parent reply other threads:[~2017-01-13 11:55 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-11 11:55 [PATCH net-next 00/13] s390: qeth patches Ursula Braun
2017-01-11 11:55 ` [PATCH net-next 01/13] s390/qeth: rework RX/TX checksum offload Ursula Braun
2017-01-11 11:55 ` [PATCH net-next 02/13] s390/qeth: test RX/TX checksum offload reply Ursula Braun
2017-01-11 11:55 ` [PATCH net-next 03/13] s390/qeth: warning for OSA3 RX/TX checksum offloading Ursula Braun
2017-01-11 11:55 ` [PATCH net-next 04/13] s390/qeth: Allow reading hsuid in state DOWN Ursula Braun
2017-01-11 11:55 ` [PATCH net-next 05/13] s390/qeth: Remove QETH_IP_HEADER_SIZE Ursula Braun
2017-01-11 11:55 ` [PATCH net-next 06/13] s390/qeth: drop qeth_l2_del_all_macs() parameter Ursula Braun
2017-01-11 11:55 ` [PATCH net-next 07/13] s390/qeth: don't convert return code twice Ursula Braun
2017-01-11 11:55 ` [PATCH net-next 08/13] s390/qeth: consolidate errno translation Ursula Braun
2017-01-11 11:55 ` [PATCH net-next 09/13] s390/qeth: extract qeth_l2_remove_mac() Ursula Braun
2017-01-11 11:55 ` [PATCH net-next 10/13] s390/qeth: shuffle MAC management functions around Ursula Braun
2017-01-11 11:55 ` [PATCH net-next 11/13] s390/qeth: issue STARTLAN as first IPA command Ursula Braun
2017-01-11 11:55 ` [PATCH net-next 12/13] s390/qeth: fix retrieval of vipa and proxy-arp addresses Ursula Braun
2017-01-11 11:56 ` [PATCH net-next 13/13] s390/qeth: remove OSN-devices Ursula Braun
2017-01-11 14:05 ` David Miller
2017-01-13 11:55 ` Ursula Braun [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3e706715-0b5f-8011-3a2d-e1f66a37661f@linux.vnet.ibm.com \
--to=ubraun@linux.vnet.ibm.com \
--cc=davem@davemloft.net \
--cc=heiko.carstens@de.ibm.com \
--cc=linux-s390@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=schwidefsky@de.ibm.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).