Netdev List
 help / color / mirror / Atom feed
From: Randy Dunlap <rdunlap@infradead.org>
To: Karl Mehltretter <kmehltretter@gmail.com>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Jonathan Corbet <corbet@lwn.net>
Cc: Shuah Khan <skhan@linuxfoundation.org>,
	Simon Horman <horms@kernel.org>,
	netdev@vger.kernel.org, linux-doc@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v2 1/2] net_shaper: fix kernel-doc list indentation
Date: Sun, 16 Aug 2026 10:13:51 -0700	[thread overview]
Message-ID: <3e782d86-6099-4c90-9e37-801bdf6d91f1@infradead.org> (raw)
In-Reply-To: <64f428350ec1450adcd0607f54f30d27a42f129c.1786751700.git.kmehltretter@gmail.com>



On 8/14/26 6:32 PM, Karl Mehltretter wrote:
> Docutils 0.22.4 reports:
> 
>   Documentation/networking/kapi:107:
>   ../include/net/net_shaper.h:82:
>   ERROR: Unexpected indentation.
> 
> Add the required blank line and correct the list indentation.
> 
> Assisted-by: Codex:gpt-5.6-sol
> Signed-off-by: Karl Mehltretter <kmehltretter@gmail.com>

Reviewed-by: Randy Dunlap <rdunlap@infradead.org>
Tested-by: Randy Dunlap <rdunlap@infradead.org>

Thanks.

> ---
>  include/net/net_shaper.h | 9 +++++----
>  1 file changed, 5 insertions(+), 4 deletions(-)
> 
> diff --git a/include/net/net_shaper.h b/include/net/net_shaper.h
> index 05cb625b0fe54..330517a1cb5c2 100644
> --- a/include/net/net_shaper.h
> +++ b/include/net/net_shaper.h
> @@ -80,10 +80,11 @@ struct net_shaper {
>   * disallowed at the uAPI level will never be made at the driver level.
>   * The shaper core performs automatic reparenting and cleanup, generating
>   * additional calls. Notably:
> - *  - @group calls in the driver facing API may have nodes as leaves (user is
> - *    only allowed to construct groups with queues as leaves)
> - *  - @group calls may update leaf's parent if the parent is about
> - *    to be removed (re-parenting nodes explicitly is not supported in the uAPI)
> + *
> + * - @group calls in the driver facing API may have nodes as leaves (user is
> + *   only allowed to construct groups with queues as leaves)
> + * - @group calls may update leaf's parent if the parent is about
> + *   to be removed (re-parenting nodes explicitly is not supported in the uAPI)
>   *
>   * Implicit creation
>   * -----------------

-- 
~Randy

  reply	other threads:[~2026-08-16 17:13 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-15  1:32 [PATCH net-next v2 0/2] net_shaper: fix kernel-doc rendering Karl Mehltretter
2026-08-15  1:32 ` [PATCH net-next v2 1/2] net_shaper: fix kernel-doc list indentation Karl Mehltretter
2026-08-16 17:13   ` Randy Dunlap [this message]
2026-08-15  1:32 ` [PATCH net-next v2 2/2] docs: kerneldoc.py: preserve headings in kernel-doc output Karl Mehltretter
2026-08-16 17:14   ` Randy Dunlap
2026-08-17 21:00 ` [PATCH net-next v2 0/2] net_shaper: fix kernel-doc rendering patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3e782d86-6099-4c90-9e37-801bdf6d91f1@infradead.org \
    --to=rdunlap@infradead.org \
    --cc=corbet@lwn.net \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=horms@kernel.org \
    --cc=kmehltretter@gmail.com \
    --cc=kuba@kernel.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=skhan@linuxfoundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox