From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jesus Sanchez-Palencia <jesus.sanchez-palencia@intel.com>
Subject: Re: [PATCH v2 net-next 02/14] net: Add a new socket option for a
 future transmit time.
Date: Mon, 9 Jul 2018 15:21:12 -0700
Message-ID: <3e97585b-f6a9-e15a-4d9f-3097704e591a@intel.com>
References: <20180703224300.25300-1-jesus.sanchez-palencia@intel.com>
 <20180703224300.25300-3-jesus.sanchez-palencia@intel.com>
 <069d42b8-b5d1-cc4f-449c-f5ccbec7fa60@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: tglx@linutronix.de, jan.altenberg@linutronix.de,
        vinicius.gomes@intel.com, kurt.kanzenbach@linutronix.de,
        henrik@austad.us, richardcochran@gmail.com,
        ilias.apalodimas@linaro.org, ivan.khoronzhuk@linaro.org,
        mlichvar@redhat.com, willemb@google.com, jhs@mojatatu.com,
        xiyou.wangcong@gmail.com, jiri@resnulli.us,
        jeffrey.t.kirsher@intel.com
To: Eric Dumazet <eric.dumazet@gmail.com>, netdev@vger.kernel.org
Return-path: <netdev-owner@vger.kernel.org>
Received: from mga12.intel.com ([192.55.52.136]:35347 "EHLO mga12.intel.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1753008AbeGIW0S (ORCPT <rfc822;netdev@vger.kernel.org>);
        Mon, 9 Jul 2018 18:26:18 -0400
In-Reply-To: <069d42b8-b5d1-cc4f-449c-f5ccbec7fa60@gmail.com>
Content-Language: en-US
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>



On 07/07/2018 05:44 PM, Eric Dumazet wrote:
> 
> 
> On 07/03/2018 03:42 PM, Jesus Sanchez-Palencia wrote:
>> From: Richard Cochran <rcochran@linutronix.de>
>>
>> This patch introduces SO_TXTIME. User space enables this option in
>> order to pass a desired future transmit time in a CMSG when calling
>> sendmsg(2). The argument to this socket option is a 8-bytes long struct
>> provided by the uapi header net_tstamp.h defined as:
>>
>> struct sock_txtime {
>> 	clockid_t 	clockid;
>> 	u32		flags;
>> };
>>
>> Note that new fields were added to struct sock by filling a 2-bytes
>> hole found in the struct. For that reason, neither the struct size or
>> number of cachelines were altered.
> 
> 
>> diff --git a/include/uapi/linux/net_tstamp.h b/include/uapi/linux/net_tstamp.h
>> index 4fe104b2411f..c9a77c353b98 100644
>> --- a/include/uapi/linux/net_tstamp.h
>> +++ b/include/uapi/linux/net_tstamp.h
>> @@ -141,4 +141,19 @@ struct scm_ts_pktinfo {
>>  	__u32 reserved[2];
>>  };
>>  
>> +/*
>> + * SO_TXTIME gets a struct sock_txtime with flags being an integer bit
>> + * field comprised of these values.
>> + */
>> +enum txtime_flags {
>> +	SOF_TXTIME_DEADLINE_MODE = (1 << 0),
>> +
>> +	SOF_TXTIME_FLAGS_MASK = (SOF_TXTIME_DEADLINE_MODE)
>> +};
>> +
>> +struct sock_txtime {
>> +	clockid_t       clockid;        /* reference clockid */
>> +	u32             flags;          /* flags defined by enum txtime_flags */
>> +};
>> +
> 
> I was under the impression that we could not use 'u32' type in include/uapi/linux/* file
> 
> This must be replaced by __u32, right ?


I'm sending a patch fixing that now, thanks.