From: Vadim Fedorenko <vadim.fedorenko@linux.dev>
To: Arnd Bergmann <arnd@kernel.org>, Fan Gong <gongfan1@huawei.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Zhu Yikai <zhuyikai1@h-partners.com>
Cc: Arnd Bergmann <arnd@arndb.de>, Xin Guo <guoxin09@huawei.com>,
Gur Stavi <gur.stavi@huawei.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [net-next] hinic3: select CONFIG_DIMLIB
Date: Fri, 6 Feb 2026 12:54:24 +0000 [thread overview]
Message-ID: <3ea3ab8b-6b12-4741-b442-b41a396ec9ad@linux.dev> (raw)
In-Reply-To: <20260205161530.1308504-1-arnd@kernel.org>
On 05/02/2026 16:13, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> The driver started using dimlib but fails to select the corresponding
> symbol, which results in a link failure:
>
> x86_64-linux-ld: drivers/net/ethernet/huawei/hinic3/hinic3_irq.o: in function `hinic3_poll':
> hinic3_irq.c:(.text+0x179): undefined reference to `net_dim'
> x86_64-linux-ld: drivers/net/ethernet/huawei/hinic3/hinic3_irq.o: in function `hinic3_rx_dim_work':
> hinic3_irq.c:(.text+0x1fb): undefined reference to `net_dim_get_rx_moderation'
>
> Fixes: b35a6fd37a00 ("hinic3: Add adaptive IRQ coalescing with DIM")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/net/ethernet/huawei/hinic3/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/ethernet/huawei/hinic3/Kconfig b/drivers/net/ethernet/huawei/hinic3/Kconfig
> index ce4331d1387b..02d6f91a7f4a 100644
> --- a/drivers/net/ethernet/huawei/hinic3/Kconfig
> +++ b/drivers/net/ethernet/huawei/hinic3/Kconfig
> @@ -11,6 +11,7 @@ config HINIC3
> depends on X86 || ARM64 || COMPILE_TEST
> depends on PCI_MSI && 64BIT
> select AUXILIARY_BUS
> + select DIMLIB
> select PAGE_POOL
> help
> This driver supports HiNIC 3rd gen Network Adapter (HINIC3).
Reviewed-by: Vadim Fedorenko <vadim.fedorenko@linux.dev>
next prev parent reply other threads:[~2026-02-06 12:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-05 16:13 [PATCH] [net-next] hinic3: select CONFIG_DIMLIB Arnd Bergmann
2026-02-06 12:54 ` Vadim Fedorenko [this message]
2026-02-07 4:20 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3ea3ab8b-6b12-4741-b442-b41a396ec9ad@linux.dev \
--to=vadim.fedorenko@linux.dev \
--cc=andrew+netdev@lunn.ch \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gongfan1@huawei.com \
--cc=guoxin09@huawei.com \
--cc=gur.stavi@huawei.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=zhuyikai1@h-partners.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox