From: Nikolay Aleksandrov <razor@blackwall.org>
To: Ido Schimmel <idosch@nvidia.com>, netdev@vger.kernel.org
Cc: davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com,
edumazet@kernel.org, jv@jvosburgh.net, andrew+netdev@lunn.ch,
aahila@google.com
Subject: Re: [PATCH net-next 2/2] selftests: bonding: Add a test for 802.3ad with coupled control disabled
Date: Fri, 13 Nov 2026 11:35:20 +0200 [thread overview]
Message-ID: <3eb2f85a-c262-4e42-a763-528edd403769@blackwall.org> (raw)
In-Reply-To: <20261111171947.2816258-2-idosch@nvidia.com>
On 11/11/2026 19:19, Ido Schimmel wrote:
> Test that with coupled control disabled, a port in COLLECTING state
> receives packets.
>
> In this mode, a port only transitions from COLLECTING to DISTRIBUTING
> state if its partner sets the Collecting bit in its LACPDUs. Therefore,
> keep the port in COLLECTING state by clearing the Collecting bit in
> received LACPDUs.
>
> Also test that ping works once the port moves to DISTRIBUTING state.
>
> Use VRFs rather than network namespaces so that the test could be run
> with a veth pair or a pair of physically connected ports.
>
> Output without "bonding: 3ad: Receive packets in COLLECTING state":
>
> # ./bond_lacp_independent_control.sh
> TEST: Receive in COLLECTING state [FAIL]
> Packets not received in COLLECTING state
> TEST: Ping in DISTRIBUTING state [ OK ]
>
> Output with the fix:
>
> # ./bond_lacp_independent_control.sh
> TEST: Receive in COLLECTING state [ OK ]
> TEST: Ping in DISTRIBUTING state [ OK ]
>
> Reviewed-by: Petr Machata <petrm@nvidia.com>
> Signed-off-by: Ido Schimmel <idosch@nvidia.com>
> ---
> .../selftests/drivers/net/bonding/Makefile | 1 +
> .../bonding/bond_lacp_independent_control.sh | 144 ++++++++++++++++++
> .../selftests/drivers/net/bonding/config | 6 +
> 3 files changed, 151 insertions(+)
> create mode 100755 tools/testing/selftests/drivers/net/bonding/bond_lacp_independent_control.sh
>
Reviewed-by: Nikolay Aleksandrov <razor@blackwall.org>
next prev parent reply other threads:[~2026-11-13 9:35 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-11 17:19 [PATCH net-next 1/2] bonding: 3ad: Receive packets in COLLECTING state Ido Schimmel
2026-11-11 17:19 ` [PATCH net-next 2/2] selftests: bonding: Add a test for 802.3ad with coupled control disabled Ido Schimmel
2026-11-12 20:21 ` netdev-bot+sashiko
2026-11-13 7:01 ` Ido Schimmel
2026-11-13 2:16 ` Hangbin Liu
2026-11-13 2:24 ` Hangbin Liu
2026-11-13 7:07 ` Ido Schimmel
2026-11-13 7:45 ` Hangbin Liu
2026-11-13 8:42 ` Ido Schimmel
2026-11-13 9:21 ` Hangbin Liu
2026-11-13 9:35 ` Nikolay Aleksandrov [this message]
2026-11-12 20:21 ` [PATCH net-next 1/2] bonding: 3ad: Receive packets in COLLECTING state netdev-bot+sashiko
2026-11-13 1:32 ` Hangbin Liu
2026-11-13 6:52 ` Ido Schimmel
2026-11-13 9:35 ` Nikolay Aleksandrov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3eb2f85a-c262-4e42-a763-528edd403769@blackwall.org \
--to=razor@blackwall.org \
--cc=aahila@google.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@kernel.org \
--cc=idosch@nvidia.com \
--cc=jv@jvosburgh.net \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox