From: Paolo Abeni <pabeni@redhat.com>
To: Harini Katakam <harini.katakam@xilinx.com>,
nicolas.ferre@microchip.com, davem@davemloft.net,
richardcochran@gmail.com, claudiu.beznea@microchip.com,
kuba@kernel.org, edumazet@google.com
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
michal.simek@xilinx.com, harinikatakamlinux@gmail.com,
radhey.shyam.pandey@xilinx.com
Subject: Re: [PATCH net v3] net: macb: Fix PTP one step sync support
Date: Thu, 19 May 2022 20:17:54 +0200 [thread overview]
Message-ID: <3ecbe9d60f555266fe09d5a8c657b87d6f7564b8.camel@redhat.com> (raw)
In-Reply-To: <20220518170756.7752-1-harini.katakam@xilinx.com>
On Wed, 2022-05-18 at 22:37 +0530, Harini Katakam wrote:
> PTP one step sync packets cannot have CSUM padding and insertion in
> SW since time stamp is inserted on the fly by HW.
> In addition, ptp4l version 3.0 and above report an error when skb
> timestamps are reported for packets that not processed for TX TS
> after transmission.
> Add a helper to identify PTP one step sync and fix the above two
> errors. Add a common mask for PTP header flag field "twoStepflag".
> Also reset ptp OSS bit when one step is not selected.
>
> Fixes: ab91f0a9b5f4 ("net: macb: Add hardware PTP support")
> Fixes: 653e92a9175e ("net: macb: add support for padding and fcs computation")
> Signed-off-by: Harini Katakam <harini.katakam@xilinx.com>
> Reviewed-by: Radhey Shyam Pandey <radhey.shyam.pandey@xilinx.com>
I'm sorry, but I cut the -net PR to Linus too early for this, so the
fix will have to wait for a little more (no need to repost!) and even
more pause will be required for the net-next follow-up.
Sorry for the inconvenince,
Paolo
next prev parent reply other threads:[~2022-05-19 18:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-18 17:07 [PATCH net v3] net: macb: Fix PTP one step sync support Harini Katakam
2022-05-19 4:40 ` Jakub Kicinski
2022-05-19 8:27 ` Claudiu.Beznea
2022-05-19 18:17 ` Paolo Abeni [this message]
2022-05-20 5:36 ` Harini Katakam
2022-05-20 0:20 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3ecbe9d60f555266fe09d5a8c657b87d6f7564b8.camel@redhat.com \
--to=pabeni@redhat.com \
--cc=claudiu.beznea@microchip.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=harini.katakam@xilinx.com \
--cc=harinikatakamlinux@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.simek@xilinx.com \
--cc=netdev@vger.kernel.org \
--cc=nicolas.ferre@microchip.com \
--cc=radhey.shyam.pandey@xilinx.com \
--cc=richardcochran@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).