netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Przemek Kitszel <przemyslaw.kitszel@intel.com>
To: Jiri Pirko <jiri@resnulli.us>
Cc: <intel-wired-lan@lists.osuosl.org>,
	Jacob Keller <jacob.e.keller@intel.com>,
	Tony Nguyen <anthony.l.nguyen@intel.com>,
	<netdev@vger.kernel.org>, Jakub Kicinski <kuba@kernel.org>,
	"Aleksandr Loktionov" <aleksandr.loktionov@intel.com>,
	Karol Kolacinski <karol.kolacinski@intel.com>,
	Grzegorz Nitka <grzegorz.nitka@intel.com>,
	Michal Schmidt <mschmidt@redhat.com>,
	Sergey Temerkhanov <sergey.temerkhanov@intel.com>
Subject: Re: [PATCH iwl-next] ice: use DSN instead of PCI BDF for ice_adapter index
Date: Mon, 10 Mar 2025 10:50:48 +0100	[thread overview]
Message-ID: <3ed3e4e5-7b28-4543-b6ef-624064540d52@intel.com> (raw)
In-Reply-To: <vt6wnwcje727xv4agzhkpe5ympcvhtgg7qbaq4hlvw42roji2r@3kwjm4togc7m>


>>> -void ice_adapter_put(const struct pci_dev *pdev)
>>> +void ice_adapter_put(struct pci_dev *pdev)
>>>   {
>>
>> A bit of a shame that this needs to be non const now.. Could
>> pci_get_dsn() be made const? Or does it do something which might modify
>> the device somehow?
> 
> Would make sense to me to make it const.

It would indeed, but to do so, one have to constify at least a few other
pci_* functions, I didn't even got to the bottom.
While I appreciate the added value of typechecks, I would like to focus
on different work, especially that there are contributors that seems to
be focused on the hunt of such cases :)

> 
> 
>>
>>>   	unsigned long index = ice_adapter_index(pdev);
>>>   	struct ice_adapter *adapter;
>>
> 


  parent reply	other threads:[~2025-03-10  9:50 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-06 21:11 [PATCH iwl-next] ice: use DSN instead of PCI BDF for ice_adapter index Przemek Kitszel
2025-03-06 23:53 ` Jacob Keller
2025-03-07 12:40   ` Jiri Pirko
2025-03-07 23:21     ` Jacob Keller
2025-03-10  9:50     ` Przemek Kitszel [this message]
2025-03-07 12:39 ` Jiri Pirko
2025-03-07 13:42   ` Temerkhanov, Sergey
2025-03-10  8:40     ` Przemek Kitszel
2025-03-10 12:23       ` Jiri Pirko
2025-03-11 10:14         ` Przemek Kitszel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3ed3e4e5-7b28-4543-b6ef-624064540d52@intel.com \
    --to=przemyslaw.kitszel@intel.com \
    --cc=aleksandr.loktionov@intel.com \
    --cc=anthony.l.nguyen@intel.com \
    --cc=grzegorz.nitka@intel.com \
    --cc=intel-wired-lan@lists.osuosl.org \
    --cc=jacob.e.keller@intel.com \
    --cc=jiri@resnulli.us \
    --cc=karol.kolacinski@intel.com \
    --cc=kuba@kernel.org \
    --cc=mschmidt@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=sergey.temerkhanov@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).