From mboxrd@z Thu Jan 1 00:00:00 1970 From: John Fastabend Subject: Re: [bpf-next PATCH v2 3/3] bpf: selftest additions for SOCKHASH Date: Sat, 28 Apr 2018 20:43:57 -0700 Message-ID: <3edef81b-5529-be5f-3a95-7565619bd347@gmail.com> References: <20180427232047.9985.3540.stgit@john-Precision-Tower-5810> <20180427232443.9985.48093.stgit@john-Precision-Tower-5810> <20180428001039.prfomdptje6ywn3k@ast-mbp> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: ast@kernel.org, daniel@iogearbox.net, netdev@vger.kernel.org To: Alexei Starovoitov Return-path: Received: from mail-io0-f194.google.com ([209.85.223.194]:40988 "EHLO mail-io0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751568AbeD2DoI (ORCPT ); Sat, 28 Apr 2018 23:44:08 -0400 Received: by mail-io0-f194.google.com with SMTP id e12-v6so6772616iob.8 for ; Sat, 28 Apr 2018 20:44:08 -0700 (PDT) In-Reply-To: <20180428001039.prfomdptje6ywn3k@ast-mbp> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 04/27/2018 05:10 PM, Alexei Starovoitov wrote: > On Fri, Apr 27, 2018 at 04:24:43PM -0700, John Fastabend wrote: >> This runs existing SOCKMAP tests with SOCKHASH map type. To do this >> we push programs into include file and build two BPF programs. One >> for SOCKHASH and one for SOCKMAP. >> >> We then run the entire test suite with each type. >> >> Signed-off-by: John Fastabend >> --- >> tools/testing/selftests/bpf/Makefile | 3 >> tools/testing/selftests/bpf/test_sockhash_kern.c | 4 >> tools/testing/selftests/bpf/test_sockmap.c | 27 +- >> tools/testing/selftests/bpf/test_sockmap_kern.c | 340 ---------------------- >> tools/testing/selftests/bpf/test_sockmap_kern.h | 340 ++++++++++++++++++++++ >> 5 files changed, 368 insertions(+), 346 deletions(-) >> create mode 100644 tools/testing/selftests/bpf/test_sockhash_kern.c >> create mode 100644 tools/testing/selftests/bpf/test_sockmap_kern.h > > Looks like it was mainly a rename of test_sockmap_kern.c into .h > but commit doesn't show it as such. > Can you redo it with 'git mv' ? > Sure, my scripts didn't have the --find-renames. Anyways should be better now in v3. Also pushed tools updates into selftest patch. Thanks, John