From: Andrew Lunn <andrew@lunn.ch>
To: Simon Dietz <dietz23838@hs-ansbach.de>
Cc: simon.dietz@plantwatch.de, andrew+netdev@lunn.ch,
davem@davemloft.net, edumazet@google.com,
johannes@sipsolutions.net, kuniyu@google.com,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [RFC PATCH net-next v0 2/6] net: fix GeoNetworking
Date: Thu, 16 Jul 2026 21:28:50 +0200 [thread overview]
Message-ID: <3ee0f1ce-cba2-43b2-9f6e-9fb7021f92db@lunn.ch> (raw)
In-Reply-To: <20260716153917.3399255-1-dietz23838@hs-ansbach.de>
> drop:
> - pr_info("Packet was dropped.");
> + //pr_info("Packet was dropped.");
> kfree_skb(skb);
Don't comment it out, remove it.
And maybe think about incriminating a counter.
> @@ -1003,21 +1031,41 @@ static int gn_rcv(struct sk_buff *skb, struct net_device *dev,
>
> switch (gh->gc_h.ht) {
> case CH_HT_GUC:
> + if (!pskb_may_pull(skb, GN_BASE_HEADER_SIZE + sizeof(struct gn_guc_header) + sizeof(struct btp_header)))
> + goto drop;
The netdev coding style asks for lines to be < 80 characters long.
We also have quite a lot of #defines for lengths of various
headers. So maybe add some _HLEN macros.
Andrew
next prev parent reply other threads:[~2026-07-16 19:28 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-16 13:58 [RFC PATCH net-next v0 0/6] net: add GeoNetworking protocol Simon Dietz
2026-07-16 13:58 ` [RFC PATCH net-next v0 1/6] " Simon Dietz
2026-07-16 15:39 ` [RFC PATCH net-next v0 2/6] net: fix GeoNetworking Simon Dietz
2026-07-16 15:49 ` [RFC PATCH net-next v0 3/6] net: further " Simon Dietz
2026-07-16 16:12 ` [RFC PATCH net-next v0 4/6] net: even " Simon Dietz
2026-07-16 16:16 ` [RFC PATCH net-next v0 5/6] net: add ppc64 support for GeoNetworking Simon Dietz
2026-07-16 16:21 ` [RFC PATCH net-next v0 6/6] net: apply RCS to GeoNetworking Simon Dietz
2026-07-16 16:39 ` Simon Dietz
2026-07-16 19:28 ` Andrew Lunn [this message]
2026-07-16 19:17 ` [RFC PATCH net-next v0 1/6] net: add GeoNetworking protocol Andrew Lunn
2026-07-17 15:40 ` [RFC PATCH net-next 0/6] " Simon Dietz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3ee0f1ce-cba2-43b2-9f6e-9fb7021f92db@lunn.ch \
--to=andrew@lunn.ch \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=dietz23838@hs-ansbach.de \
--cc=edumazet@google.com \
--cc=johannes@sipsolutions.net \
--cc=kuniyu@google.com \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=simon.dietz@plantwatch.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).