From: "H. Peter Anvin" <hpa@zytor.com>
To: David Miller <davem@davemloft.net>, torvalds@linux-foundation.org
Cc: ast@plumgrid.com, dborkman@redhat.com, mingo@kernel.org,
wad@chromium.org, rostedt@goodmis.org, a.p.zijlstra@chello.nl,
hagen@jauu.net, jesse@nicira.com, tglx@linutronix.de,
edumazet@google.com, akpm@linux-foundation.org,
fweisbec@gmail.com, acme@infradead.org, penberg@iki.fi,
arjan@infradead.org, hch@infradead.org, xemul@parallels.com,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH v8 net-next 1/3] filter: add Extended BPF interpreter and converter
Date: Mon, 10 Mar 2014 19:33:03 -0700 [thread overview]
Message-ID: <3ee8da10-166e-45c1-925a-f089085fdff4@email.android.com> (raw)
In-Reply-To: <20140310.222449.561233409099006984.davem@davemloft.net>
Why not for variables? It makes a lot of sense of nothing else to avoid the confusion that invariably happens when someone decides to introduce the value 2 or -1 to an existing variable (and yes, thus has happened a number of times.)
Not to mention they take a single byte rather than four for an int if stored in memory.
On March 10, 2014 7:24:49 PM PDT, David Miller <davem@davemloft.net> wrote:
>From: Linus Torvalds <torvalds@linux-foundation.org>
>Date: Mon, 10 Mar 2014 19:02:18 -0700
>
>> I would generally suggest that people only use "bool" for function
>> return types, and absolutely nothing else. Seriously.
>
>I think it makes sense for function arguments too.
--
Sent from my mobile phone. Please pardon brevity and lack of formatting.
next prev parent reply other threads:[~2014-03-11 2:33 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-10 6:04 [PATCH v8 net-next 0/3] filter: add Extended BPF interpreter and converter, seccomp Alexei Starovoitov
2014-03-10 6:04 ` [PATCH v8 net-next 1/3] filter: add Extended BPF interpreter and converter Alexei Starovoitov
2014-03-11 1:51 ` David Miller
2014-03-11 2:02 ` Linus Torvalds
2014-03-11 2:05 ` Linus Torvalds
2014-03-11 2:20 ` H. Peter Anvin
2014-03-11 2:57 ` Alexei Starovoitov
2014-03-11 2:24 ` David Miller
2014-03-11 2:33 ` H. Peter Anvin [this message]
2014-03-11 2:39 ` David Miller
2014-03-11 3:05 ` Linus Torvalds
2014-03-11 9:51 ` David Laight
2014-03-11 3:02 ` Joe Perches
2014-03-10 6:04 ` [PATCH v8 net-next 2/3] seccomp: convert seccomp to use extended BPF Alexei Starovoitov
2014-03-10 6:04 ` [PATCH v8 net-next 3/3] doc: filter: add Extended BPF documentation Alexei Starovoitov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3ee8da10-166e-45c1-925a-f089085fdff4@email.android.com \
--to=hpa@zytor.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=arjan@infradead.org \
--cc=ast@plumgrid.com \
--cc=davem@davemloft.net \
--cc=dborkman@redhat.com \
--cc=edumazet@google.com \
--cc=fweisbec@gmail.com \
--cc=hagen@jauu.net \
--cc=hch@infradead.org \
--cc=jesse@nicira.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=penberg@iki.fi \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=wad@chromium.org \
--cc=xemul@parallels.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox