From mboxrd@z Thu Jan 1 00:00:00 1970 From: "H. Peter Anvin" Subject: Re: [PATCH v8 net-next 1/3] filter: add Extended BPF interpreter and converter Date: Mon, 10 Mar 2014 19:33:03 -0700 Message-ID: <3ee8da10-166e-45c1-925a-f089085fdff4@email.android.com> References: <1394431444-6987-2-git-send-email-ast@plumgrid.com> <20140310.215104.2095195123238829635.davem@davemloft.net> <20140310.222449.561233409099006984.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: ast@plumgrid.com, dborkman@redhat.com, mingo@kernel.org, wad@chromium.org, rostedt@goodmis.org, a.p.zijlstra@chello.nl, hagen@jauu.net, jesse@nicira.com, tglx@linutronix.de, edumazet@google.com, akpm@linux-foundation.org, fweisbec@gmail.com, acme@infradead.org, penberg@iki.fi, arjan@infradead.org, hch@infradead.org, xemul@parallels.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org To: David Miller , torvalds@linux-foundation.org Return-path: In-Reply-To: <20140310.222449.561233409099006984.davem@davemloft.net> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org Why not for variables? It makes a lot of sense of nothing else to avoid the confusion that invariably happens when someone decides to introduce the value 2 or -1 to an existing variable (and yes, thus has happened a number of times.) Not to mention they take a single byte rather than four for an int if stored in memory. On March 10, 2014 7:24:49 PM PDT, David Miller wrote: >From: Linus Torvalds >Date: Mon, 10 Mar 2014 19:02:18 -0700 > >> I would generally suggest that people only use "bool" for function >> return types, and absolutely nothing else. Seriously. > >I think it makes sense for function arguments too. -- Sent from my mobile phone. Please pardon brevity and lack of formatting.