From: David Ahern <dsahern@gmail.com>
To: Jakub Kicinski <kubakici@wp.pl>, Martin KaFai Lau <kafai@fb.com>,
Hannes Frederic Sowa <hannes@stressinduktion.org>
Cc: netdev@vger.kernel.org, Alexei Starovoitov <ast@fb.com>,
Daniel Borkmann <daniel@iogearbox.net>,
kernel-team@fb.com
Subject: Re: [PATCH v2 net-next 0/8] Introduce bpf ID
Date: Thu, 1 Jun 2017 07:55:47 -0600 [thread overview]
Message-ID: <3f269312-efd4-86fc-e8e2-814af5898648@gmail.com> (raw)
In-Reply-To: <20170531192256.0e0d0ce1@cakuba.lan>
On 5/31/17 8:22 PM, Jakub Kicinski wrote:
> On Wed, 31 May 2017 11:58:54 -0700, Martin KaFai Lau wrote:
>> This patch series:
>> 1) Introduce ID for both bpf_prog and bpf_map.
>> 2) Add bpf commands to iterate the prog IDs and map
>> IDs of the system.
>> 3) Add bpf commands to get a prog/map fd from an ID
>> 4) Add bpf command to get prog/map info from a fd.
>> The prog/map info is a jump start in this patchset
>> and it is not meant to be a complete list. They can
>> be extended in the future patches.
>
> Hi! IIUC there were plans at some point to store the BPF byte code in
> the kernel, the way it was loaded from the user space and before it
> went through the verifier. Are you still planning on implementing that?
> It would be handy for offloads to have the original byte code, things
> like call inlining make translations of maps calls a bit challenging,
> since we try to run through the verifier again..
>
Save the instructions:
https://github.com/dsahern/linux/commit/5315578db7b0886a3e8e3bef6a56e828ae2bd2c4
Let userspace read it back:
https://github.com/dsahern/linux/commit/619982064b9b582fc5d4a504feffca1730610c4e
One more in between in the branch:
https://github.com/dsahern/linux/tree/bpf/retrieve-bpf-wip
Now that the id code is in, it needs to be returned on link dumps, route
dumps, etc and accessible via fdinfo. The id can be turned into an fd
and the fd read using the above patches.
next prev parent reply other threads:[~2017-06-01 13:55 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-31 18:58 [PATCH v2 net-next 0/8] Introduce bpf ID Martin KaFai Lau
2017-05-31 18:58 ` [PATCH v2 net-next 1/8] bpf: Introduce bpf_prog ID Martin KaFai Lau
2017-05-31 18:58 ` [PATCH v2 net-next 2/8] bpf: Introduce bpf_map ID Martin KaFai Lau
2017-05-31 18:58 ` [PATCH v2 net-next 3/8] bpf: Add BPF_(PROG|MAP)_GET_NEXT_ID command Martin KaFai Lau
2017-05-31 18:58 ` [PATCH v2 net-next 4/8] bpf: Add BPF_PROG_GET_FD_BY_ID Martin KaFai Lau
2017-05-31 18:58 ` [PATCH v2 net-next 5/8] bpf: Add BPF_MAP_GET_FD_BY_ID Martin KaFai Lau
2017-05-31 18:59 ` [PATCH v2 net-next 6/8] bpf: Add jited_len to struct bpf_prog Martin KaFai Lau
2017-05-31 18:59 ` [PATCH v2 net-next 7/8] bpf: Add BPF_OBJ_GET_INFO_BY_FD Martin KaFai Lau
2017-05-31 18:59 ` [PATCH v2 net-next 8/8] bpf: Test for bpf ID Martin KaFai Lau
2017-05-31 23:35 ` [PATCH v2 net-next 0/8] Introduce " David Miller
2017-06-03 1:08 ` Martin KaFai Lau
2017-06-01 2:22 ` Jakub Kicinski
2017-06-01 13:55 ` David Ahern [this message]
2017-06-01 17:24 ` Alexei Starovoitov
2017-06-01 17:51 ` David Ahern
2017-06-01 18:27 ` Alexei Starovoitov
2017-06-01 18:33 ` David Miller
2017-06-01 18:57 ` Jakub Kicinski
2017-06-01 18:52 ` David Ahern
2017-06-01 18:56 ` David Miller
2017-06-01 19:00 ` Jakub Kicinski
2017-06-01 21:48 ` Alexei Starovoitov
2017-06-02 11:39 ` David Ahern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3f269312-efd4-86fc-e8e2-814af5898648@gmail.com \
--to=dsahern@gmail.com \
--cc=ast@fb.com \
--cc=daniel@iogearbox.net \
--cc=hannes@stressinduktion.org \
--cc=kafai@fb.com \
--cc=kernel-team@fb.com \
--cc=kubakici@wp.pl \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).