netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Alexander Lobakin <aleksander.lobakin@intel.com>
To: Richard Gobert <richardbgobert@gmail.com>
Cc: <davem@davemloft.net>, <edumazet@google.com>, <kuba@kernel.org>,
	<pabeni@redhat.com>, <lixiaoyan@google.com>,
	<lucien.xin@gmail.com>, <alexanderduyck@fb.com>,
	<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 0/1] gro: decrease size of CB
Date: Fri, 2 Jun 2023 16:22:19 +0200	[thread overview]
Message-ID: <3f6cd784-767e-02e3-0c30-c0dda12e51ab@intel.com> (raw)
In-Reply-To: <20230601160924.GA9194@debian>

From: Richard Gobert <richardbgobert@gmail.com>
Date: Thu, 1 Jun 2023 18:09:28 +0200

> This patch frees up space in the GRO CB, which is currently at its maximum
> size. This patch was submitted and reviewed previously in a patch series,
> but is now reposted as a standalone patch, as suggested by Paolo.
> (https://lore.kernel.org/netdev/889f2dc5e646992033e0d9b0951d5a42f1907e07.camel@redhat.com/)
> 
> Changelog:
> 
> v2 -> v3:
>   * add comment
> 
> v1 -> v2:
>   * remove inline keyword

I hope you've checked that there's no difference in object code with and
w/o `inline`? Sometimes the compilers do weird things and stop inlining
oneliners if they're used more than once. skb_gro_reset_offset() is
marked `inline` exactly due to that =\

> 
> Richard Gobert (1):
>   gro: decrease size of CB
> 
>  include/net/gro.h | 26 ++++++++++++++++----------
>  net/core/gro.c    | 19 ++++++++++++-------
>  2 files changed, 28 insertions(+), 17 deletions(-)
Thanks,
Olek

  parent reply	other threads:[~2023-06-02 14:23 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-01 16:09 [PATCH v3 0/1] gro: decrease size of CB Richard Gobert
2023-06-01 16:14 ` [PATCH v3 1/1] " Richard Gobert
2023-06-06  7:25   ` Eric Dumazet
2023-06-26  8:55   ` Gal Pressman
2023-06-27 14:21     ` David Ahern
     [not found]       ` <b3908ce2-43e1-b56d-5d1d-48a932a2a016@nvidia.com>
2023-06-28 14:19         ` David Ahern
2023-08-23 14:43           ` Gal Pressman
2023-08-24  3:31             ` David Ahern
2023-06-29 12:36     ` Richard Gobert
     [not found]       ` <431d8445-9593-73df-d431-d5e76c9085cf@nvidia.com>
2023-06-30 15:39         ` Richard Gobert
2023-07-02 14:41           ` Gal Pressman
2023-07-02 14:46             ` Gal Pressman
2023-07-03 14:23               ` Richard Gobert
2023-07-07 12:31                 ` Richard Gobert
2023-07-09  6:55                   ` Gal Pressman
2023-06-02 14:22 ` Alexander Lobakin [this message]
2023-06-05 13:58   ` [PATCH v3 0/1] " Richard Gobert
2023-06-06 13:24     ` Alexander Lobakin
2023-06-06  9:20 ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3f6cd784-767e-02e3-0c30-c0dda12e51ab@intel.com \
    --to=aleksander.lobakin@intel.com \
    --cc=alexanderduyck@fb.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lixiaoyan@google.com \
    --cc=lucien.xin@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=richardbgobert@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).