From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joe Perches Subject: Re: [net-next 12/12] igc: Clean up code Date: Thu, 08 Nov 2018 03:00:56 -0800 Message-ID: <3f712fcf9f86cc3cdca3d6f937d1d1af165a11af.camel@perches.com> References: <20181107224830.9737-1-jeffrey.t.kirsher@intel.com> <20181107224830.9737-13-jeffrey.t.kirsher@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Cc: Sasha Neftin , netdev@vger.kernel.org, nhorman@redhat.com, sassmann@redhat.com To: Jeff Kirsher , davem@davemloft.net Return-path: Received: from smtprelay0170.hostedemail.com ([216.40.44.170]:59709 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726304AbeKHUf4 (ORCPT ); Thu, 8 Nov 2018 15:35:56 -0500 In-Reply-To: <20181107224830.9737-13-jeffrey.t.kirsher@intel.com> Sender: netdev-owner@vger.kernel.org List-ID: On Wed, 2018-11-07 at 14:48 -0800, Jeff Kirsher wrote: > From: Sasha Neftin > > Address few community comments. > Remove unused code, will be added per demand. > Remove blank lines and unneeded includes. > > Signed-off-by: Sasha Neftin > Tested-by: Aaron Brown > Signed-off-by: Jeff Kirsher > --- > drivers/net/ethernet/intel/igc/igc.h | 9 --------- > drivers/net/ethernet/intel/igc/igc_main.c | 15 --------------- > 2 files changed, 24 deletions(-) > > diff --git a/drivers/net/ethernet/intel/igc/igc.h b/drivers/net/ethernet/intel/igc/igc.h [] > #define IGC_ERR(args...) pr_err("igc: " args) This is used just once and should probably be removed. maybe: --- drivers/net/ethernet/intel/igc/igc_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/intel/igc/igc_main.c b/drivers/net/ethernet/intel/igc/igc_main.c index 9d85707e8a81..b58542b20623 100644 --- a/drivers/net/ethernet/intel/igc/igc_main.c +++ b/drivers/net/ethernet/intel/igc/igc_main.c @@ -3551,7 +3551,7 @@ static int igc_probe(struct pci_dev *pdev, err = dma_set_coherent_mask(&pdev->dev, DMA_BIT_MASK(32)); if (err) { - IGC_ERR("Wrong DMA configuration, aborting\n"); + dev_err(&pdev->dev, "igc: Wrong DMA configuration, aborting\n"); goto err_dma; } }