From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Ahern Subject: Re: [PATCH net-next 12/18] ipv6: Teach tree walker to skip multipath routes Date: Sun, 7 Jan 2018 10:04:10 -0700 Message-ID: <3f8f5c39-9e46-5280-ef9f-d9b2f25ffd78@gmail.com> References: <20180107104518.31693-1-idosch@mellanox.com> <20180107104518.31693-13-idosch@mellanox.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: davem@davemloft.net, roopa@cumulusnetworks.com, nicolas.dichtel@6wind.com, weiwan@google.com, kafai@fb.com, yoshfuji@linux-ipv6.org, mlxsw@mellanox.com To: Ido Schimmel , netdev@vger.kernel.org Return-path: Received: from mail-pf0-f169.google.com ([209.85.192.169]:33645 "EHLO mail-pf0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754074AbeAGREN (ORCPT ); Sun, 7 Jan 2018 12:04:13 -0500 Received: by mail-pf0-f169.google.com with SMTP id y89so4310021pfk.0 for ; Sun, 07 Jan 2018 09:04:12 -0800 (PST) In-Reply-To: <20180107104518.31693-13-idosch@mellanox.com> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 1/7/18 3:45 AM, Ido Schimmel wrote: > As explained in previous patch, fib6_ifdown() needs to consider the > state of all the sibling routes when a multipath route is traversed. > > This is done by evaluating all the siblings when the first sibling in a > multipath route is traversed. If the multipath route does not need to be > flushed (e.g., not all siblings are dead), then we should just skip the > multipath route as our work is done. > > Have the tree walker jump to the last sibling when it is determined that > the multipath route needs to be skipped. > > Signed-off-by: Ido Schimmel > --- > net/ipv6/ip6_fib.c | 11 +++++++++-- > 1 file changed, 9 insertions(+), 2 deletions(-) > Acked-by: David Ahern