From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jaswinder Singh Rajput Subject: Re: [PULL -tip] fixed few make headers_check warnings Date: Wed, 14 Jan 2009 21:29:35 +0530 Message-ID: <3f9a31f40901140759s1542e6cclae1808b796c2b1a9@mail.gmail.com> References: <1231836016.3212.41.camel@jaswinder.satnam> <3f9a31f40901140129i1389f47frf32808f3a695a118@mail.gmail.com> <20090114153825.GB32082@uranus.ravnborg.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Geert Uytterhoeven , Jaswinder Singh Rajput , Ingo Molnar , Alan Cox , Andrew Morton , David Miller , x86 maintainers , LKML , netdev To: Sam Ravnborg Return-path: Received: from wa-out-1112.google.com ([209.85.146.180]:7701 "EHLO wa-out-1112.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756711AbZANP7g (ORCPT ); Wed, 14 Jan 2009 10:59:36 -0500 In-Reply-To: <20090114153825.GB32082@uranus.ravnborg.org> Sender: netdev-owner@vger.kernel.org List-ID: Hello Sam, On Wed, Jan 14, 2009 at 9:08 PM, Sam Ravnborg wrote: >> > > > I appreciate your work but I will like to question the approach. My approach was: "PATCH should solve a problem per file", like: capability.h: extern's make no sense in userspace coda_psdev.h: extern's make no sense in userspace in6.h: extern's make no sense in userspace nubus.h: extern's make no sense in userspace socket.h: extern's make no sense in userspace But this warnings was in many files: include of is preferred over : 15 files found __[us]{8,16,32,64} type without #include : 52 files So in place of making 15 + 52 = 67 patches, I made 2 patches for each warning. > We should rather take the warnings as an indication that this > file needs to be looked over and fix not only the warnings > reported but rater to fix all the questionable issues on a file-by-file basis. Should I make 67 patches ? -- JSR