From: Jaswinder Singh Rajput <jaswinderlinux@gmail.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Sam Ravnborg <sam@ravnborg.org>,
Jaswinder Singh Rajput <jaswinder@infradead.org>,
Ingo Molnar <mingo@elte.hu>, Alan Cox <alan@lxorguk.ukuu.org.uk>,
Andrew Morton <akpm@linux-foundation.org>,
David Miller <davem@davemloft.net>,
x86 maintainers <x86@kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
netdev <netdev@vger.kernel.org>
Subject: Re: [PULL -tip] fixed few make headers_check warnings
Date: Wed, 14 Jan 2009 22:28:19 +0530 [thread overview]
Message-ID: <3f9a31f40901140858w3a024023h94ebb1a6e087d03e@mail.gmail.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0901141732450.26663@anakin>
On Wed, Jan 14, 2009 at 10:06 PM, Geert Uytterhoeven
<geert@linux-m68k.org> wrote:
> What Sam means is that the warnings about externs not making sense in userspace
> are indicators that there may be other external declarations (without "extern")
> in those files, and that you should fix those at the same time (i.e. either
> don't fix any of them, or fix all of them (in the same file)). If you don't
> fix them at the same time, people tend to forget about them.
>
> So the warnings are just considered canaries in our coal mine. Killing only the
> canaries doesn't help.
>
If this is the case, then drop extern patches and let maintainers of
those files should handle them then they will not forget and never
repeat this mistake again.
--
JSR
next prev parent reply other threads:[~2009-01-14 16:58 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-13 8:40 [PULL -tip] fixed few make headers_check warnings Jaswinder Singh Rajput
2009-01-13 12:49 ` Ingo Molnar
2009-01-13 21:03 ` David Miller
2009-01-14 15:40 ` Sam Ravnborg
2009-01-14 15:58 ` Oliver Hartkopp
2009-01-15 10:54 ` Ingo Molnar
2009-01-14 8:56 ` Geert Uytterhoeven
2009-01-14 9:29 ` Jaswinder Singh Rajput
2009-01-14 15:38 ` Sam Ravnborg
2009-01-14 15:59 ` Jaswinder Singh Rajput
2009-01-14 16:36 ` Geert Uytterhoeven
2009-01-14 16:58 ` Jaswinder Singh Rajput [this message]
2009-01-14 20:15 ` Sam Ravnborg
2009-01-15 11:11 ` Ingo Molnar
2009-01-15 14:37 ` Sam Ravnborg
2009-01-15 14:47 ` Jaswinder Singh Rajput
2009-01-15 14:50 ` Ingo Molnar
2009-01-15 14:51 ` Ingo Molnar
2009-01-15 15:16 ` Jaswinder Singh Rajput
2009-01-15 15:33 ` Ingo Molnar
2009-01-15 14:49 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3f9a31f40901140858w3a024023h94ebb1a6e087d03e@mail.gmail.com \
--to=jaswinderlinux@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=davem@davemloft.net \
--cc=geert@linux-m68k.org \
--cc=jaswinder@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=netdev@vger.kernel.org \
--cc=sam@ravnborg.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).