Netdev List
 help / color / mirror / Atom feed
From: Andrii Nakryiko <andriin@fb.com>
To: Jesper Dangaard Brouer <brouer@redhat.com>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Cc: Daniel Borkmann <borkmann@iogearbox.net>,
	Alexei Starovoitov <ast@fb.com>
Subject: Re: [PATCH bpf-next] bpf, doc: fix BTF docs reflow of bullet list
Date: Mon, 25 Mar 2019 16:08:48 +0000	[thread overview]
Message-ID: <3fb99ad7-80ea-b821-757e-1837778bd94b@fb.com> (raw)
In-Reply-To: <155352313528.16104.299642621713828843.stgit@carbon>

On 3/25/19 7:12 AM, Jesper Dangaard Brouer wrote:
> Section 2.2.1 BTF_KIND_INT a bullet list was collapsed due to
> text reflow in commit 9ab5305dbe3f ("docs/btf: reflow text to
> fill up to 78 characters").
>
> This patch correct the mistake. Also adjust next bullet list,
> which is used for comparison, to get rendered the same way.
>
> Fixes: 9ab5305dbe3f ("docs/btf: reflow text to fill up to 78 characters")
> Link: https://www.kernel.org/doc/html/latest/bpf/btf.html#btf-kind-int
> Signed-off-by: Jesper Dangaard Brouer <brouer@redhat.com>
> ---
>  Documentation/bpf/btf.rst |    8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/Documentation/bpf/btf.rst b/Documentation/bpf/btf.rst
> index 9a60a5d60e38..7313d354f20e 100644
> --- a/Documentation/bpf/btf.rst
> +++ b/Documentation/bpf/btf.rst
> @@ -148,16 +148,16 @@ The ``btf_type.size * 8`` must be equal to or greater than ``BTF_INT_BITS()``
>  for the type. The maximum value of ``BTF_INT_BITS()`` is 128.
>  
>  The ``BTF_INT_OFFSET()`` specifies the starting bit offset to calculate values
> -for this int. For example, a bitfield struct member has: * btf member bit
> -offset 100 from the start of the structure, * btf member pointing to an int
> -type, * the int type has ``BTF_INT_OFFSET() = 2`` and ``BTF_INT_BITS() = 4``
> +for this int. For example, a bitfield struct member has:
> + * btf member bit offset 100 from the start of the structure,
> + * btf member pointing to an int type,
> + * the int type has ``BTF_INT_OFFSET() = 2`` and ``BTF_INT_BITS() = 4``

Oh, missed this one, thanks for fixing!

Acked-by: Andrii Nakryiko <andriin@fb.com>

>  
>  Then in the struct memory layout, this member will occupy ``4`` bits starting
>  from bits ``100 + 2 = 102``.
>  
>  Alternatively, the bitfield struct member can be the following to access the
>  same bits as the above:
> -
>   * btf member bit offset 102,
>   * btf member pointing to an int type,
>   * the int type has ``BTF_INT_OFFSET() = 0`` and ``BTF_INT_BITS() = 4``
>

  reply	other threads:[~2019-03-25 16:09 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-25 14:12 [PATCH bpf-next] bpf, doc: fix BTF docs reflow of bullet list Jesper Dangaard Brouer
2019-03-25 16:08 ` Andrii Nakryiko [this message]
2019-03-26 20:14 ` Alexei Starovoitov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3fb99ad7-80ea-b821-757e-1837778bd94b@fb.com \
    --to=andriin@fb.com \
    --cc=ast@fb.com \
    --cc=borkmann@iogearbox.net \
    --cc=brouer@redhat.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox